From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54267C4321A for ; Tue, 11 Jun 2019 06:08:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3580F20820 for ; Tue, 11 Jun 2019 06:08:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391144AbfFKGIq (ORCPT ); Tue, 11 Jun 2019 02:08:46 -0400 Received: from verein.lst.de ([213.95.11.211]:48379 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391044AbfFKGIq (ORCPT ); Tue, 11 Jun 2019 02:08:46 -0400 Received: by newverein.lst.de (Postfix, from userid 2407) id 29D2768B02; Tue, 11 Jun 2019 08:08:17 +0200 (CEST) Date: Tue, 11 Jun 2019 08:08:16 +0200 From: Christoph Hellwig To: Benjamin Herrenschmidt Cc: Larry Finger , Aaro Koskinen , Christoph Hellwig , Christian Zigotzky , Michael Ellerman , linuxppc-dev@lists.ozlabs.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [BISECTED REGRESSION] b43legacy broken on G4 PowerBook Message-ID: <20190611060816.GA20158@lst.de> References: <20190605225059.GA9953@darkstar.musicnaut.iki.fi> <73da300c-871c-77ac-8a3a-deac226743ef@lwfinger.net> <7697a9d10777b28ae79fdffdde6d0985555f6310.camel@kernel.crashing.org> <3ed1ccfe-d7ca-11b9-17b3-303d1ae1bb0f@lwfinger.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Tue, Jun 11, 2019 at 03:56:33PM +1000, Benjamin Herrenschmidt wrote: > The reason I think it sort-of-mostly-worked is that to get more than > 1GB of RAM, those machines use CONFIG_HIGHMEM. And *most* network > buffers aren't allocated in Highmem.... so you got lucky. > > That said, there is such as thing as no-copy send on network, so I > wouldn't be surprised if some things would still have failed, just not > frequent enough for you to notice. Unless NETIF_F_HIGHDMA is set on a netdev, the core networkign code will bounce buffer highmem pages for the driver under all circumstances.