From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Cc: Lorenzo Bianconi <lorenzo@kernel.org>,
nbd@nbd.name, kvalo@codeaurora.org,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2 1/2] mt76: usb: fix rx A-MSDU support
Date: Wed, 12 Jun 2019 12:00:16 +0200 [thread overview]
Message-ID: <20190612100014.GA4431@redhat.com> (raw)
In-Reply-To: <20190612094519.GC8107@localhost.localdomain>
On Wed, Jun 12, 2019 at 11:45:21AM +0200, Lorenzo Bianconi wrote:
> > > +mt76u_build_rx_skb(u8 *data, int len, int buf_size,
> > > + int *nsgs)
> > > +{
> > > + int data_len = min(len, MT_SKB_HEAD_LEN);
Oh, and this looks unneeded as well as for len < MT_SKB_HEAD_LEN=128
we will go through fast path.
> > mt7601u and iwlmvm just copy hdrlen + 8 and put the rest
> > of the buffer in fragment, which supose to be more efficient,
> > see comment in iwl_mvm_pass_packet_to_mac80211().
>
> Right here we copy 128B instead of 32 but I think it is good to have L3 and L4
> header in the linear area of the skb since otherwise the stack will need to
> align them
Not sure if understand, I think aliment of L3 & L4 headers will be
the same, assuming ieee80211 header is aligned the same in fragment
buffer and in linear area. But if you think this is better to copy those
to linear area I'm ok with that.
Stanislaw
next prev parent reply other threads:[~2019-06-12 10:00 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-31 9:38 [PATCH v2 0/2] mt76: usb: fix A-MSDU support Lorenzo Bianconi
2019-05-31 9:38 ` [PATCH v2 1/2] mt76: usb: fix rx " Lorenzo Bianconi
2019-06-12 8:58 ` Stanislaw Gruszka
2019-06-12 9:45 ` Lorenzo Bianconi
2019-06-12 10:00 ` Stanislaw Gruszka [this message]
2019-06-12 10:21 ` Lorenzo Bianconi
2019-06-12 10:58 ` Stanislaw Gruszka
2019-06-12 11:17 ` Lorenzo Bianconi
2019-05-31 9:38 ` [PATCH v2 2/2] mt76: usb: do not always copy the first part of received frames Lorenzo Bianconi
2019-06-12 9:10 ` Stanislaw Gruszka
2019-06-12 9:53 ` Lorenzo Bianconi
2019-06-12 10:25 ` Stanislaw Gruszka
2019-06-12 10:49 ` Lorenzo Bianconi
2019-06-12 11:51 ` Stanislaw Gruszka
2019-06-12 12:28 ` Lorenzo Bianconi
2019-06-12 12:59 ` Stanislaw Gruszka
2019-06-12 14:21 ` Stanislaw Gruszka
2019-06-12 14:44 ` Lorenzo Bianconi
2019-06-13 7:51 ` Stanislaw Gruszka
2019-06-13 8:26 ` Lorenzo Bianconi
2019-06-13 9:02 ` Stanislaw Gruszka
2019-06-13 9:06 ` Lorenzo Bianconi
2019-06-12 14:27 ` Lorenzo Bianconi
2019-06-13 7:55 ` Stanislaw Gruszka
2019-06-06 8:47 ` [PATCH v2 0/2] mt76: usb: fix A-MSDU support Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190612100014.GA4431@redhat.com \
--to=sgruszka@redhat.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=lorenzo@kernel.org \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).