From: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: Lorenzo Bianconi <lorenzo@kernel.org>,
nbd@nbd.name, kvalo@codeaurora.org,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2 2/2] mt76: usb: do not always copy the first part of received frames
Date: Wed, 12 Jun 2019 16:27:42 +0200 [thread overview]
Message-ID: <20190612142741.GA7016@localhost.localdomain> (raw)
In-Reply-To: <20190612125905.GB2600@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 663 bytes --]
> On Wed, Jun 12, 2019 at 02:28:48PM +0200, Lorenzo Bianconi wrote:
[...]
> >
> > using sg buffers we can support bigger rx AMSDU size in the future without using
> > huge buffers (e.g. we can try to use IEEE80211_MAX_MPDU_LEN_HT_7935 with
> > mt76x2u)
>
> I think it would be simpler just to allocate 2 pages for 7935B .
>
We should avoid increasing buffer size to more than PAGE_SIZE for
performance reasons. As suggested by Felix what about of setting buf_size to
PAGE_SIZE for both sg and non-sg cases and for sg setting usb data size to
SKB_WITH_OVERHEAD(q->buf_size) & (usb_endpoint_maxp() - 1);
Regards,
Lorenzo
> Stanislaw
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2019-06-12 14:27 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-31 9:38 [PATCH v2 0/2] mt76: usb: fix A-MSDU support Lorenzo Bianconi
2019-05-31 9:38 ` [PATCH v2 1/2] mt76: usb: fix rx " Lorenzo Bianconi
2019-06-12 8:58 ` Stanislaw Gruszka
2019-06-12 9:45 ` Lorenzo Bianconi
2019-06-12 10:00 ` Stanislaw Gruszka
2019-06-12 10:21 ` Lorenzo Bianconi
2019-06-12 10:58 ` Stanislaw Gruszka
2019-06-12 11:17 ` Lorenzo Bianconi
2019-05-31 9:38 ` [PATCH v2 2/2] mt76: usb: do not always copy the first part of received frames Lorenzo Bianconi
2019-06-12 9:10 ` Stanislaw Gruszka
2019-06-12 9:53 ` Lorenzo Bianconi
2019-06-12 10:25 ` Stanislaw Gruszka
2019-06-12 10:49 ` Lorenzo Bianconi
2019-06-12 11:51 ` Stanislaw Gruszka
2019-06-12 12:28 ` Lorenzo Bianconi
2019-06-12 12:59 ` Stanislaw Gruszka
2019-06-12 14:21 ` Stanislaw Gruszka
2019-06-12 14:44 ` Lorenzo Bianconi
2019-06-13 7:51 ` Stanislaw Gruszka
2019-06-13 8:26 ` Lorenzo Bianconi
2019-06-13 9:02 ` Stanislaw Gruszka
2019-06-13 9:06 ` Lorenzo Bianconi
2019-06-12 14:27 ` Lorenzo Bianconi [this message]
2019-06-13 7:55 ` Stanislaw Gruszka
2019-06-06 8:47 ` [PATCH v2 0/2] mt76: usb: fix A-MSDU support Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190612142741.GA7016@localhost.localdomain \
--to=lorenzo.bianconi@redhat.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=nbd@nbd.name \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).