From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE834C0650E for ; Wed, 3 Jul 2019 10:58:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D12602189E for ; Wed, 3 Jul 2019 10:58:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726598AbfGCK6C (ORCPT ); Wed, 3 Jul 2019 06:58:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:4006 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725820AbfGCK6C (ORCPT ); Wed, 3 Jul 2019 06:58:02 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E843881DF1; Wed, 3 Jul 2019 10:58:01 +0000 (UTC) Received: from localhost (ovpn-204-28.brq.redhat.com [10.40.204.28]) by smtp.corp.redhat.com (Postfix) with ESMTP id 54AAC1001B14; Wed, 3 Jul 2019 10:58:01 +0000 (UTC) Date: Wed, 3 Jul 2019 12:58:00 +0200 From: Stanislaw Gruszka To: Greg Kroah-Hartman Cc: Helmut Schaa , Kalle Valo , "David S. Miller" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] rt2x00: no need to check return value of debugfs_create functions Message-ID: <20190703105759.GB30509@redhat.com> References: <20190703065631.GA28822@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190703065631.GA28822@kroah.com> User-Agent: Mutt/1.11.3 (2019-02-01) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Wed, 03 Jul 2019 10:58:02 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Wed, Jul 03, 2019 at 08:56:31AM +0200, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Because we don't need to save the individual debugfs files and > directories, remove the local storage of them and just remove the entire > debugfs directory in a single call, making things a lot simpler. > > Cc: Stanislaw Gruszka > Cc: Helmut Schaa > Cc: Kalle Valo > Cc: "David S. Miller" > Cc: linux-wireless@vger.kernel.org > Cc: netdev@vger.kernel.org > Signed-off-by: Greg Kroah-Hartman > --- > .../net/wireless/ralink/rt2x00/rt2x00debug.c | 100 ++++-------------- > 1 file changed, 23 insertions(+), 77 deletions(-) This patch will not apply on wireless-drivers-next due to my recent change which add new debugfs file: commit e7f15d58dfe43f18199251f430d7713b0b8fad34 Author: Stanislaw Gruszka Date: Thu May 2 11:07:00 2019 +0200 rt2x00: add restart hw Could you please rebase the patch ? (I can do this as well if you want me to). Stanislaw