From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AE4DC06511 for ; Wed, 3 Jul 2019 11:08:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 366B621882 for ; Wed, 3 Jul 2019 11:08:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562152097; bh=eUAofhSVMslURLsFFrIei9Cjn3qD2rxuwcSKgkuaHB4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=LhnQtXAFr9dTspXSv2mHvO/wXIdZKy8YSH4lEtg2FBsatUSUW2E1Y0wgvqOhr6yuC emdZltQ/D2q57xolyPdgGnni40Mz/SfiTe/0umFWIhMQxDmspIbspyOgX2uZN5I+G+ PLcSTlKSoekAgG0M50ALZ+UZlbjqaUHPAsObqctk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726768AbfGCLIP (ORCPT ); Wed, 3 Jul 2019 07:08:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:46914 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726621AbfGCLIO (ORCPT ); Wed, 3 Jul 2019 07:08:14 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 425E721882; Wed, 3 Jul 2019 11:08:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562152093; bh=eUAofhSVMslURLsFFrIei9Cjn3qD2rxuwcSKgkuaHB4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=xo5f1QcvJZiCFHf6wkH3yfSpiAGhvudzsCoWPukPJnDsBvYgzqXtIMxertwJ6h1oL Y0KMp3H0VbNylkO2G7KjYQztVxjIKyBM9w+p/b9JPGiuHeP7RjWSaj7/G0/+z3xvP0 nrsm9li85lEptjkCEMXrDnRgYh6kOrVDvT8RFVjA= Date: Wed, 3 Jul 2019 13:08:10 +0200 From: Greg Kroah-Hartman To: Stanislaw Gruszka Cc: Helmut Schaa , Kalle Valo , "David S. Miller" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] rt2x00: no need to check return value of debugfs_create functions Message-ID: <20190703110810.GA18323@kroah.com> References: <20190703065631.GA28822@kroah.com> <20190703105759.GB30509@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190703105759.GB30509@redhat.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Wed, Jul 03, 2019 at 12:58:00PM +0200, Stanislaw Gruszka wrote: > On Wed, Jul 03, 2019 at 08:56:31AM +0200, Greg Kroah-Hartman wrote: > > When calling debugfs functions, there is no need to ever check the > > return value. The function can work or not, but the code logic should > > never do something different based on this. > > > > Because we don't need to save the individual debugfs files and > > directories, remove the local storage of them and just remove the entire > > debugfs directory in a single call, making things a lot simpler. > > > > Cc: Stanislaw Gruszka > > Cc: Helmut Schaa > > Cc: Kalle Valo > > Cc: "David S. Miller" > > Cc: linux-wireless@vger.kernel.org > > Cc: netdev@vger.kernel.org > > Signed-off-by: Greg Kroah-Hartman > > --- > > .../net/wireless/ralink/rt2x00/rt2x00debug.c | 100 ++++-------------- > > 1 file changed, 23 insertions(+), 77 deletions(-) > > This patch will not apply on wireless-drivers-next due to my recent > change which add new debugfs file: > > commit e7f15d58dfe43f18199251f430d7713b0b8fad34 > Author: Stanislaw Gruszka > Date: Thu May 2 11:07:00 2019 +0200 > > rt2x00: add restart hw > > Could you please rebase the patch ? (I can do this as well > if you want me to). No problem, I can rebase and redo it, I'll go suck down the wireless-drivers-next tree and resend it, thanks for leting me know. greg k-h