From: Kalle Valo <kvalo@codeaurora.org>
To: Dan Williams <dcbw@redhat.com>
Cc: Philip Rakity <prakity@yahoo.com>,
libertas-dev@lists.infradead.org,
kernel-janitors@vger.kernel.org, linux-wireless@vger.kernel.org,
Lubomir Rintel <lkundrak@v3.sk>,
Allison Randal <allison@lohutok.net>,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH v2] libertas: Fix a double free in if_spi_c2h_data()
Date: Wed, 24 Jul 2019 11:46:43 +0000 (UTC) [thread overview]
Message-ID: <20190724114644.65BAB60ACE@smtp.codeaurora.org> (raw)
In-Reply-To: <ee4472e4728becc9713962ba264742cb1f337098.camel@redhat.com>
Dan Williams <dcbw@redhat.com> wrote:
> The lbs_process_rxed_packet() frees the skb. It didn't originally, but
> we fixed it in commit f54930f36311 ("libertas: don't leak skb on receive
> error").
>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Dan Williams <dcbw@redhat.com>
Failed to compile:
drivers/net/wireless/marvell/libertas/if_spi.c: In function 'if_spi_c2h_data':
drivers/net/wireless/marvell/libertas/if_spi.c:771:11: error: expected ';' before '}' token
goto out
^
;
}
~
make[5]: *** [drivers/net/wireless/marvell/libertas/if_spi.o] Error 1
make[4]: *** [drivers/net/wireless/marvell/libertas] Error 2
make[3]: *** [drivers/net/wireless/marvell] Error 2
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [drivers/net/wireless] Error 2
make[1]: *** [drivers/net] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [drivers] Error 2
Patch set to Changes Requested.
--
https://patchwork.kernel.org/patch/11033059/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2019-07-24 11:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-26 10:09 [PATCH] libertas: Fix a double free in if_spi_c2h_data() Dan Carpenter
2019-06-26 13:16 ` Dan Williams
2019-06-26 13:23 ` Dan Carpenter
2019-06-26 16:02 ` Dan Williams
2019-07-05 16:42 ` [PATCH v2] " Dan Williams
2019-07-24 11:46 ` Kalle Valo [this message]
2019-07-24 14:38 ` [PATCH v3] " Dan Williams
2019-08-06 12:36 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190724114644.65BAB60ACE@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=allison@lohutok.net \
--cc=dan.carpenter@oracle.com \
--cc=dcbw@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lkundrak@v3.sk \
--cc=prakity@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).