From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Tony Chuang <yhchuang@realtek.com>
Cc: "kvalo@codeaurora.org" <kvalo@codeaurora.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"briannorris@chromium.org" <briannorris@chromium.org>
Subject: Re: [PATCH v2 5/5] rtw88: add BT co-existence support
Date: Tue, 30 Jul 2019 08:34:04 +0200 [thread overview]
Message-ID: <20190730063403.GA3174@redhat.com> (raw)
In-Reply-To: <F7CD281DE3E379468C6D07993EA72F84D1881C82@RTITMBSVM04.realtek.com.tw>
On Tue, Jul 30, 2019 at 03:13:35AM +0000, Tony Chuang wrote:
> > Those coex response skb buffers are allocated in rtw_pci_rx_isr(),
> > but I do not see where they are freed (seems we do not process
> > them in c2h_work which does dev_kfree_skb()).
>
> You're right, that SKB leaked. Should free them after responded.
> I will send v2 to fix it :)
FWIW maybe would be better to process coex commands entairly in
c2h_work ? Not sure if that would work or really would be better,
just an idea you can consider :-)
Stanislaw
prev parent reply other threads:[~2019-07-30 6:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-25 2:53 [PATCH v2 0/5] rtw88: add support for BT co-existence mechanism yhchuang
2019-07-25 2:53 ` [PATCH v2 1/5] rtw88: switch specified efuse bank yhchuang
2019-07-25 2:53 ` [PATCH v2 2/5] rtw88: check efuse for BT FT S1 yhchuang
2019-07-25 2:53 ` [PATCH v2 3/5] rtw88: allow c2h operation in irq context yhchuang
2019-07-25 2:53 ` [PATCH v2 4/5] rtw88: enclose c2h cmd handle with mutex yhchuang
2019-07-25 2:53 ` [PATCH v2 5/5] rtw88: add BT co-existence support yhchuang
2019-07-29 8:12 ` Stanislaw Gruszka
2019-07-30 3:13 ` Tony Chuang
2019-07-30 6:34 ` Stanislaw Gruszka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190730063403.GA3174@redhat.com \
--to=sgruszka@redhat.com \
--cc=briannorris@chromium.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=yhchuang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).