From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 434EEC433FF for ; Tue, 30 Jul 2019 14:04:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 20EE8206E0 for ; Tue, 30 Jul 2019 14:04:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729222AbfG3OEj (ORCPT ); Tue, 30 Jul 2019 10:04:39 -0400 Received: from mx2.suse.de ([195.135.220.15]:50774 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728255AbfG3OEj (ORCPT ); Tue, 30 Jul 2019 10:04:39 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id E3328ADCB; Tue, 30 Jul 2019 14:04:37 +0000 (UTC) Date: Tue, 30 Jul 2019 16:04:36 +0200 From: Jean Delvare To: Johannes Berg Cc: linux-wireless@vger.kernel.org, Peter Lebbing , Felix Fietkau , Toke =?UTF-8?B?SMO4aWxhbmQtSsO4cmdlbnNlbg==?= , Johannes Berg Subject: Re: [PATCH] Revert "mac80211: set NETIF_F_LLTX when using intermediate tx queues" Message-ID: <20190730160436.78b72b50@endymion> In-Reply-To: <20190730125412.1446-1-johannes@sipsolutions.net> References: <20190730125412.1446-1-johannes@sipsolutions.net> Organization: SUSE Linux X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Tue, 30 Jul 2019 14:54:11 +0200, Johannes Berg wrote: > From: Johannes Berg > > Revert this for now, it has been reported multiple times that it > completely breaks connectivity on various devices. > > Cc: stable@vger.kernel.org > Fixes: 8dbb000ee73b ("mac80211: set NETIF_F_LLTX when using intermediate tx queues") > Reported-by: Jean Delvare > Reported-by: Peter Lebbing > Signed-off-by: Johannes Berg > --- > net/mac80211/iface.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/net/mac80211/iface.c b/net/mac80211/iface.c > index 06aac0aaae64..8dc6580e1787 100644 > --- a/net/mac80211/iface.c > +++ b/net/mac80211/iface.c > @@ -1222,7 +1222,6 @@ static void ieee80211_if_setup(struct net_device *dev) > static void ieee80211_if_setup_no_queue(struct net_device *dev) > { > ieee80211_if_setup(dev); > - dev->features |= NETIF_F_LLTX; > dev->priv_flags |= IFF_NO_QUEUE; > } > Thanks Johannes. Tested-by: Jean Delvare -- Jean Delvare SUSE L3 Support