* [PATCH] Revert "mac80211: set NETIF_F_LLTX when using intermediate tx queues"
@ 2019-07-30 12:54 Johannes Berg
2019-07-30 14:04 ` Jean Delvare
2019-07-31 11:29 ` Peter Lebbing
0 siblings, 2 replies; 3+ messages in thread
From: Johannes Berg @ 2019-07-30 12:54 UTC (permalink / raw)
To: linux-wireless
Cc: Jean Delvare, Peter Lebbing, Felix Fietkau,
Toke Høiland-Jørgensen, Johannes Berg
From: Johannes Berg <johannes.berg@intel.com>
Revert this for now, it has been reported multiple times that it
completely breaks connectivity on various devices.
Cc: stable@vger.kernel.org
Fixes: 8dbb000ee73b ("mac80211: set NETIF_F_LLTX when using intermediate tx queues")
Reported-by: Jean Delvare <jdelvare@suse.de>
Reported-by: Peter Lebbing <peter@digitalbrains.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---
net/mac80211/iface.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/mac80211/iface.c b/net/mac80211/iface.c
index 06aac0aaae64..8dc6580e1787 100644
--- a/net/mac80211/iface.c
+++ b/net/mac80211/iface.c
@@ -1222,7 +1222,6 @@ static void ieee80211_if_setup(struct net_device *dev)
static void ieee80211_if_setup_no_queue(struct net_device *dev)
{
ieee80211_if_setup(dev);
- dev->features |= NETIF_F_LLTX;
dev->priv_flags |= IFF_NO_QUEUE;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] Revert "mac80211: set NETIF_F_LLTX when using intermediate tx queues"
2019-07-30 12:54 [PATCH] Revert "mac80211: set NETIF_F_LLTX when using intermediate tx queues" Johannes Berg
@ 2019-07-30 14:04 ` Jean Delvare
2019-07-31 11:29 ` Peter Lebbing
1 sibling, 0 replies; 3+ messages in thread
From: Jean Delvare @ 2019-07-30 14:04 UTC (permalink / raw)
To: Johannes Berg
Cc: linux-wireless, Peter Lebbing, Felix Fietkau,
Toke Høiland-Jørgensen, Johannes Berg
On Tue, 30 Jul 2019 14:54:11 +0200, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> Revert this for now, it has been reported multiple times that it
> completely breaks connectivity on various devices.
>
> Cc: stable@vger.kernel.org
> Fixes: 8dbb000ee73b ("mac80211: set NETIF_F_LLTX when using intermediate tx queues")
> Reported-by: Jean Delvare <jdelvare@suse.de>
> Reported-by: Peter Lebbing <peter@digitalbrains.com>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> ---
> net/mac80211/iface.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/net/mac80211/iface.c b/net/mac80211/iface.c
> index 06aac0aaae64..8dc6580e1787 100644
> --- a/net/mac80211/iface.c
> +++ b/net/mac80211/iface.c
> @@ -1222,7 +1222,6 @@ static void ieee80211_if_setup(struct net_device *dev)
> static void ieee80211_if_setup_no_queue(struct net_device *dev)
> {
> ieee80211_if_setup(dev);
> - dev->features |= NETIF_F_LLTX;
> dev->priv_flags |= IFF_NO_QUEUE;
> }
>
Thanks Johannes.
Tested-by: Jean Delvare <jdelvare@suse.de>
--
Jean Delvare
SUSE L3 Support
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Revert "mac80211: set NETIF_F_LLTX when using intermediate tx queues"
2019-07-30 12:54 [PATCH] Revert "mac80211: set NETIF_F_LLTX when using intermediate tx queues" Johannes Berg
2019-07-30 14:04 ` Jean Delvare
@ 2019-07-31 11:29 ` Peter Lebbing
1 sibling, 0 replies; 3+ messages in thread
From: Peter Lebbing @ 2019-07-31 11:29 UTC (permalink / raw)
To: Johannes Berg; +Cc: linux-wireless
On 30/07/2019 14:54, Johannes Berg wrote:
> Revert this for now, it has been reported multiple times that it
> completely breaks connectivity on various devices.
That was quick! Thank you!
Peter.
--
I use the GNU Privacy Guard (GnuPG) in combination with Enigmail.
You can send me encrypted mail if you want some privacy.
My key is available at <http://digitalbrains.com/2012/openpgp-key-peter>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-31 11:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-30 12:54 [PATCH] Revert "mac80211: set NETIF_F_LLTX when using intermediate tx queues" Johannes Berg
2019-07-30 14:04 ` Jean Delvare
2019-07-31 11:29 ` Peter Lebbing
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).