From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABA1BC31E40 for ; Tue, 6 Aug 2019 12:36:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 82C182070D for ; Tue, 6 Aug 2019 12:36:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="n/NFR8e6"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="Dg5fiiKl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730120AbfHFMgU (ORCPT ); Tue, 6 Aug 2019 08:36:20 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:60238 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726711AbfHFMgU (ORCPT ); Tue, 6 Aug 2019 08:36:20 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 30B4260EA5; Tue, 6 Aug 2019 12:36:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1565094979; bh=bj8qWGpk0Sk8b4h8M0Ne5LXuOnmgHgbZr/8RgDNfuP8=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=n/NFR8e6uXdTOcxgC4FYIIvCgEMowGv40S/7M0PSyT6SAGCDRg5MGpGmHuGvm5vBh ib6wt+geuP1GBMibxUhUmrV5qC+dfT6HiJmaCnT/f3C/tfGhfeXiF7MzTSqOK1zVx6 OFcFpbc7JEHrWCTHa2aPrw/8e1HnVod+towgJzWI= Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id B25CB608BA; Tue, 6 Aug 2019 12:36:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1565094976; bh=bj8qWGpk0Sk8b4h8M0Ne5LXuOnmgHgbZr/8RgDNfuP8=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=Dg5fiiKl+2LFh3I+pWjL092hV7TngoKzborRoN74EW4KRcpbs+nwMTI6RVw1whISe sPqJUsINYQRPWt+aFM0DPXndUOosh3IOcu4Fslc/8GUp6RGiElz9h/0mTAg33nr+qA eo5CGPUblez1eRYjIdhjMH6gQwrd835cZBPv1BHU= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org B25CB608BA Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v3] libertas: Fix a double free in if_spi_c2h_data() From: Kalle Valo In-Reply-To: <9153261627a0f84b996e023f1349a2bc06dd03ee.camel@redhat.com> References: <9153261627a0f84b996e023f1349a2bc06dd03ee.camel@redhat.com> To: Dan Williams Cc: Philip Rakity , libertas-dev@lists.infradead.org, kernel-janitors@vger.kernel.org, linux-wireless@vger.kernel.org, Lubomir Rintel , Dan Carpenter , Allison Randal User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20190806123619.30B4260EA5@smtp.codeaurora.org> Date: Tue, 6 Aug 2019 12:36:18 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Dan Williams wrote: > The lbs_process_rxed_packet() frees the skb. It didn't originally, but > we fixed it in commit f54930f36311 ("libertas: don't leak skb on receive > error"). > > Reported-by: Dan Carpenter > Signed-off-by: Dan Williams Patch applied to wireless-drivers-next.git, thanks. 3915a252ce71 libertas: Fix a double free in if_spi_c2h_data() -- https://patchwork.kernel.org/patch/11057049/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches