From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBEBDC31E40 for ; Tue, 6 Aug 2019 12:43:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C17BC20818 for ; Tue, 6 Aug 2019 12:43:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="IelaEY+6"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="DELvPZdd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730363AbfHFMnn (ORCPT ); Tue, 6 Aug 2019 08:43:43 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:35996 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726036AbfHFMnn (ORCPT ); Tue, 6 Aug 2019 08:43:43 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id AC16760590; Tue, 6 Aug 2019 12:43:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1565095421; bh=BCfOHP9HalrfoaTlPtuAMFW08YetxuZS+9N/gnYCrcM=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=IelaEY+6xGLR5+MMKwJ9GMsg70XLbQd0SkIk5v0krnKOAed0SeOGLHpM9CLp5XGHy jW+1pRD/WqDItPPj/wUvt6Z2vVZ8CjmrU44ReGopXDQriFdWaPVT0LzZxTvrAQJJKS u/UVHe3dGBm2dVGqmiPP2e/wYDxksMhCxCWGejhk= Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 6275D6038E; Tue, 6 Aug 2019 12:43:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1565095421; bh=BCfOHP9HalrfoaTlPtuAMFW08YetxuZS+9N/gnYCrcM=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=DELvPZddHzuOW75TzKQ8L1rBkd2CJigWaTTdyz2vjfstbme25QsONOBFVbO2H9oJF juCzegsAMysv8H0rCrtu2jyZ6ocAJR1mlteIilxgqivabmcpvzFXLG+yGXRF5nZLUs dD0ZCk0MZo//WX1d3Qi2Al97Ex3VejH9sgsbn578= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 6275D6038E Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] Revert "mwifiex: fix system hang problem after resume" From: Kalle Valo In-Reply-To: <20190805171504.48122-1-briannorris@chromium.org> References: <20190805171504.48122-1-briannorris@chromium.org> To: Brian Norris Cc: Amitkumar Karwar , Nishant Sarmukadam , Ganapathi Bhat , Xinming Hu , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Dmitry Torokhov , Doug Anderson , Matthias Kaehlcke , Brian Norris , Amitkumar Karwar User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20190806124341.AC16760590@smtp.codeaurora.org> Date: Tue, 6 Aug 2019 12:43:41 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Brian Norris wrote: > This reverts commit 437322ea2a36d112e20aa7282c869bf924b3a836. > > This above-mentioned "fix" does not actually do anything to prevent a > race condition. It simply papers over it so that the issue doesn't > appear. > > If this is a real problem, it should be explained better than the above > commit does, and an alternative, non-racy solution should be found. > > For further reason to revert this: there's no reason we can't try > resetting the card when it's *actually* stuck in host-sleep mode. So > instead, this is unnecessarily creating scenarios where we can't recover > Wifi (and in fact, I'm fielding reports of Chromebooks that can't > recover after the aforementioned commit). > > Note that this was proposed in 2017 and Ack'ed then, but due to my > marking as RFC, it never went anywhere: > > https://patchwork.kernel.org/patch/9657277/ > [RFC] Revert "mwifiex: fix system hang problem after resume" > > Cc: Amitkumar Karwar > Signed-off-by: Brian Norris > Reviewed-by: Dmitry Torokhov > Acked-by: Amitkumar Karwar > Tested-by: Matthias Kaehlcke Patch applied to wireless-drivers-next.git, thanks. 654026df2635 Revert "mwifiex: fix system hang problem after resume" -- https://patchwork.kernel.org/patch/11077645/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches