Linux wireless drivers development
 help / color / mirror / Atom feed
From: Stuart Little <achirvasub@gmail.com>
To: Luciano Coelho <luciano.coelho@intel.com>
Cc: Serge Belyshev <belyshev@depni.sinp.msu.ru>,
	Johannes Berg <johannes.berg@intel.com>,
	Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
	kernel list <linux-kernel@vger.kernel.org>,
	Intel Linux Wireless <linuxwifi@intel.com>,
	linux-wireless@vger.kernel.org,
	Haim Dreyfuss <haim.dreyfuss@intel.com>
Subject: Re: PROBLEM: 5.3.0-rc* causes iwlwifi failure
Date: Tue, 20 Aug 2019 19:37:34 -0400	[thread overview]
Message-ID: <20190820233734.GA1406@chirva-slack.chirva-slack> (raw)
In-Reply-To: <1b1e573e6502c97851838a3b27ac0b272198926c.camel@intel.com>

On Tue, Aug 20, 2019 at 01:45:37PM +0300, Luciano Coelho wrote:
> I'll have to look into all NIC/FW-version combinations that we have and
> update the iwl_mvm_sar_geo_support() function accordingly, which is,
> BTW, the easier place for you to change if you want to workaround the
> issue.

Thanks!

I didn't quite know how to interpret this suggestion (i.e. what the change should be), so I was poking around in there out of curiosity. One simple-minded thing that worked was to just pretend that that function always returns false:

--- cut here ---

diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c
index 5de54d1559dd..8c0160e5588f 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c
@@ -925,7 +925,7 @@ int iwl_mvm_get_sar_geo_profile(struct iwl_mvm *mvm)
                .data = { data },
        };
 
-       if (!iwl_mvm_sar_geo_support(mvm))
+       /*if (!iwl_mvm_sar_geo_support(mvm))*/
                return -EOPNOTSUPP;
 
        ret = iwl_mvm_send_cmd(mvm, &cmd);
@@ -953,7 +953,7 @@ static int iwl_mvm_sar_geo_init(struct iwl_mvm *mvm)
        int ret, i, j;
        u16 cmd_wide_id =  WIDE_ID(PHY_OPS_GROUP, GEO_TX_POWER_LIMIT);
 
-       if (!iwl_mvm_sar_geo_support(mvm))
+       /*if (!iwl_mvm_sar_geo_support(mvm))*/
                return 0;
 
        ret = iwl_mvm_sar_get_wgds_table(mvm);

--- cut here ---

  reply	other threads:[~2019-08-20 23:37 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-17  4:12 PROBLEM: 5.3.0-rc* causes iwlwifi failure Stuart Little
2019-08-17  5:30 ` Stuart Little
2019-08-17  8:59 ` Serge Belyshev
2019-08-17 13:45   ` Stuart Little
2019-08-17 21:44   ` Stuart Little
2019-08-20 10:45     ` Luciano Coelho
2019-08-20 23:37       ` Stuart Little [this message]
2019-08-21  5:04         ` Luciano Coelho
2019-08-21  6:49       ` Sedat Dilek
     [not found] ` <20191208203810.GA2920@system76-pc.localdomain>
2019-12-11  5:20   ` PROBLEM: iwlwifi in 5.4 does not load firmware for A.C.
     [not found]   ` <20191222224207.GA2408@system76-pc.localdomain>
     [not found]     ` <ec9092a28196f24c39051b89f9dc87b40942b6de.camel@intel.com>
     [not found]       ` <20191223125742.GA2586@system76-pc.localdomain>
2019-12-23 13:01         ` PROBLEM: iwlwifi in 5.4 does not load firmware for Intel device 9560 Luciano Coelho
     [not found] <20190817214448.GB1070 () chirva-slack ! chirva-slack>
2019-08-18  8:17 ` PROBLEM: 5.3.0-rc* causes iwlwifi failure Chris Clayton
2019-08-18 10:55   ` Stuart Little
2019-08-22  8:59     ` Chris Clayton
2019-08-22 14:27       ` Luca Coelho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190820233734.GA1406@chirva-slack.chirva-slack \
    --to=achirvasub@gmail.com \
    --cc=belyshev@depni.sinp.msu.ru \
    --cc=emmanuel.grumbach@intel.com \
    --cc=haim.dreyfuss@intel.com \
    --cc=johannes.berg@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linuxwifi@intel.com \
    --cc=luciano.coelho@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox