From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48AA7C3A59E for ; Wed, 21 Aug 2019 08:47:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1B43A22D6D for ; Wed, 21 Aug 2019 08:47:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727839AbfHUIr3 (ORCPT ); Wed, 21 Aug 2019 04:47:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42506 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726715AbfHUIr3 (ORCPT ); Wed, 21 Aug 2019 04:47:29 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id ECD5C308212A; Wed, 21 Aug 2019 08:47:28 +0000 (UTC) Received: from localhost (ovpn-204-173.brq.redhat.com [10.40.204.173]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2310F5D9E1; Wed, 21 Aug 2019 08:47:25 +0000 (UTC) Date: Wed, 21 Aug 2019 10:47:24 +0200 From: Stanislaw Gruszka To: Felix Fietkau Cc: Lorenzo Bianconi , linux-wireless , Ryder Lee , Roy Luo Subject: Re: [PATCH 5.3] mt76: mt76x0e: don't use hw encryption for MT7630E Message-ID: <20190821084724.GB20223@redhat.com> References: <1565703400-10623-1-git-send-email-sgruszka@redhat.com> <20190815100936.GA21775@redhat.com> <727fd528-16c1-e3b3-e1a9-2edbcbdddee7@nbd.name> <20190819110639.GA6037@redhat.com> <7b46ab63-d69d-f389-b3c2-245cbe11c7b7@nbd.name> <20190820112438.GA2227@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190820112438.GA2227@redhat.com> User-Agent: Mutt/1.11.3 (2019-02-01) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Wed, 21 Aug 2019 08:47:29 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Tue, Aug 20, 2019 at 01:24:39PM +0200, Stanislaw Gruszka wrote: > > Can you test if disabling hw encryption only for shared or only for > > pairwise keys makes any difference? > > Disabling only pairwise keys helps. Disabling only shared keys does > not help. > > Not sure if this will be helpful information or make things more > confusing, but seems the difference between mt76_txq_schedule() > and tasklet_schedule() in mt76_wake_tx_queue() is that on > mt76_txq_schedule() some tx packets are serialized by dev->rx_lock > (because some ARP and TCP packets are sent via network stack as response > of incoming packet within ieee80211_rx_napi() call). Removing > spin_lock(&dev->rx_lock) in mt76_rx_complete() make the problem > reproducible again with mt76_txq_schedule() & HW encryption. So, I think this is FW/HW issue related with encryption and ordering and we should apply patch originally posted in this thread that disable HW encryption for MT7630E. I do not think we should disable HW encryption only for pairwise keys, because FW/HW can have the same bug for shared keys, but is not triggered in my test, as we do not sent lot of group frames. Stanislaw