From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Felix Fietkau <nbd@nbd.name>
Cc: linux-wireless@vger.kernel.org,
Lorenzo Bianconi <lorenzo.bianconi@redhat.com>,
Ryder Lee <ryder.lee@mediatek.com>, Roy Luo <royluo@google.com>
Subject: Re: [PATCH 1/3] mt76: remove redundant mt76_txq_schedule_all
Date: Fri, 23 Aug 2019 12:20:37 +0200 [thread overview]
Message-ID: <20190823102036.GA6523@redhat.com> (raw)
In-Reply-To: <a7ba0815-5e5c-c88f-c07c-c7d2a6a0714d@nbd.name>
On Fri, Aug 23, 2019 at 11:27:41AM +0200, Felix Fietkau wrote:
> On 2019-08-23 10:52, Stanislaw Gruszka wrote:
> > Waking tx queues will cause that txq's will be scheduled. Calling
> > mt76_txq_schedule_all() while queues are blocked is not necessary.
> > We will not get any skb's from ieee80211_tx_dequeue() anyway, but
> > patch changes that transmit of mtxq->retry_q skb's will be a bit
> > deferred (on the moment after channel switch or other situation
> > when we wake up queues).
> >
> > Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
> Waking tx queues will not always cause txqs to be scheduled - only if an
> attempt to dequeue was blocked because queues were stopped at that time.
> Because of that, I don't think this patch is correct.
Ok, please drop it.
Stanislaw
next prev parent reply other threads:[~2019-08-23 10:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-23 8:52 [PATCH 0/3] mt76: channel switch related cleanups Stanislaw Gruszka
2019-08-23 8:52 ` [PATCH 1/3] mt76: remove redundant mt76_txq_schedule_all Stanislaw Gruszka
2019-08-23 9:27 ` Felix Fietkau
2019-08-23 10:20 ` Stanislaw Gruszka [this message]
2019-08-23 8:52 ` [PATCH 2/3] mt76: mt76x0: remove redundant chandef copy Stanislaw Gruszka
2019-08-23 8:52 ` [PATCH 3/3] mt76: mt76x0: remove unneeded return value on set channel Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190823102036.GA6523@redhat.com \
--to=sgruszka@redhat.com \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=nbd@nbd.name \
--cc=royluo@google.com \
--cc=ryder.lee@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).