From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E3EFC3A5A2 for ; Tue, 3 Sep 2019 13:45:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 11CCB2087E for ; Tue, 3 Sep 2019 13:45:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="Ca/rZzPT"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="Y48Wol2Z" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729137AbfICNpS (ORCPT ); Tue, 3 Sep 2019 09:45:18 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:55560 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727624AbfICNpS (ORCPT ); Tue, 3 Sep 2019 09:45:18 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id E92A4602A9; Tue, 3 Sep 2019 13:45:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1567518316; bh=SZXWTCjqpiIvW/RjC2cgF+Cvh3PDxr4gm1GoQYsANAc=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=Ca/rZzPT9MLVZHKOPL3uysvDFsKMDFKuSjvOacfGIKIOsFXeqR/qvNUItwL6ZAlxg zC9/NWHEqikTyeFP3EySLqAmsO9dO617jwtOAXAuoUX4/FhXEqcXOwXuTAxSJd3iek RbE4TDyTuF846kTtcFB4InWk2yRHyZIHYnN+eXhw= Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id C481160159; Tue, 3 Sep 2019 13:45:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1567518316; bh=SZXWTCjqpiIvW/RjC2cgF+Cvh3PDxr4gm1GoQYsANAc=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=Y48Wol2ZIk4AgKtysBFOfSSNGlW2PxCXTzFESqk9tq9NKJGWVZtAZzYwkEG0XUxqZ H237KLtBaDoadnQJpfxF4oY687CvJn+ADi3z31/LWcuB90+xuwNBf0Aj0JS5NHd0am M2D04K0HTvTqHIsX/7aKy/KaArjTXaDYhbdHku1s= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org C481160159 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH -next] brcmfmac: get chip's default RAM info during PCIe setup From: Kalle Valo In-Reply-To: <20190829082701.1715-1-zajec5@gmail.com> References: <20190829082701.1715-1-zajec5@gmail.com> To: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= Cc: Arend van Spriel , Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , Winnie Chang , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com, =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20190903134516.E92A4602A9@smtp.codeaurora.org> Date: Tue, 3 Sep 2019 13:45:16 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Rafał Miłecki wrote: > From: Rafał Miłecki > > Getting RAM info just once per driver's lifetime (during chip > recognition) is not enough as it may get adjusted later (depending on > the used firmware). Subsequent inits may load different firmwares so a > full RAM recognition is required on every PCIe setup. This is especially > important since implementing hardware reset on a firmware crash. > > Moreover calling brcmf_chip_get_raminfo() makes sure that RAM core is > up. It's important as having BCMA_CORE_SYS_MEM down on BCM4366 was > resulting in firmware failing to initialize and following error: > [ 65.657546] brcmfmac 0000:01:00.0: brcmf_pcie_download_fw_nvram: Invalid shared RAM address 0x04000001 > > This change makes brcmf_chip_get_raminfo() call during chip recognition > redundant for PCIe devices but SDIO and USB still need it and it's a > very small overhead anyway. > > Fixes: 4684997d9eea ("brcmfmac: reset PCIe bus on a firmware crash") > Signed-off-by: Rafał Miłecki Patch applied to wireless-drivers-next.git, thanks. 82f93cf46d60 brcmfmac: get chip's default RAM info during PCIe setup -- https://patchwork.kernel.org/patch/11120633/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches