From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89B24C3A5A2 for ; Tue, 3 Sep 2019 13:52:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5DA6923711 for ; Tue, 3 Sep 2019 13:52:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="bfFa64sV"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="i0YgikAu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729344AbfICNwQ (ORCPT ); Tue, 3 Sep 2019 09:52:16 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:59294 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728854AbfICNwQ (ORCPT ); Tue, 3 Sep 2019 09:52:16 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id A052560878; Tue, 3 Sep 2019 13:52:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1567518735; bh=mU5Z0XEhHaYA24ducmb3V/8wh8mFYozJt7ceVgcFlpU=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=bfFa64sVQVpNarGh/ilpMCvlJXqw17yGyCawsJL8Jby5fafQCQNSEEdWxOBFChGfJ 2jC8A4Z6NM/TOaki3QrwxX8ihfZs6kO0rcIvmLbmFzNJZd+QifYlyEtjn73yEMA6Qn csRKsIjPQ4T1CMwOCl+7L6NZu6SrsmvWmeopuldA= Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id E0BFF6076A; Tue, 3 Sep 2019 13:52:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1567518733; bh=mU5Z0XEhHaYA24ducmb3V/8wh8mFYozJt7ceVgcFlpU=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=i0YgikAuQ+M3/AtAJD/HQolYntrysV3cUpbf9vL8r/WWFecOjDQABWUkNZoqCLSLD 8t54OZQFcrdEN2B1Dwjxg5AqQ4KDQig4khtr5+IVaFsDuiAsCTxvIqlIDvcuXjWott WG9O1Lns/DmsTP2/LZb6smA6O7L5xM6v5+fHnbw4= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org E0BFF6076A Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH 5.3] rt2x00: clear up IV's on key removal From: Kalle Valo In-Reply-To: <1566564483-31088-1-git-send-email-sgruszka@redhat.com> References: <1566564483-31088-1-git-send-email-sgruszka@redhat.com> To: Stanislaw Gruszka Cc: linux-wireless@vger.kernel.org, Felix Fietkau , Daniel Golle , =?utf-8?q?Tomislav_Po=C5=BEega?= , Mathias Kresin , Emil Karlson , Fredrik Noring User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20190903135215.A052560878@smtp.codeaurora.org> Date: Tue, 3 Sep 2019 13:52:14 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Stanislaw Gruszka wrote: > After looking at code I realized that my previous fix > 95844124385e ("rt2x00: clear IV's on start to fix AP mode regression") > was incomplete. We can still have wrong IV's after re-keyring. > To fix that, clear up IV's also on key removal. > > Fixes: 710e6cc1595e ("rt2800: do not nullify initialization vector data") > Signed-off-by: Stanislaw Gruszka > tested-by: Emil Karlson Patch applied to wireless-drivers.git, thanks. 14d5e14c8a6c rt2x00: clear up IV's on key removal -- https://patchwork.kernel.org/patch/11111605/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches