From: Kalle Valo <kvalo@codeaurora.org>
To: Colin King <colin.king@canonical.com>
Cc: Michael Buesch <m@bues.ch>,
linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ssb: make array pwr_info_offset static const, makes object smaller
Date: Fri, 13 Sep 2019 14:23:35 +0000 (UTC) [thread overview]
Message-ID: <20190913142335.C25DF607F1@smtp.codeaurora.org> (raw)
In-Reply-To: <20190906154053.32218-1-colin.king@canonical.com>
Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate the array pwr_info_offset on the stack but instead make it
> static const. Makes the object code smaller by 207 bytes.
>
> Before:
> text data bss dec hex filename
> 26066 3000 64 29130 71ca drivers/ssb/pci.o
>
> After:
> text data bss dec hex filename
> 25763 3096 64 28923 70fb drivers/ssb/pci.o
>
> (gcc version 9.2.1, amd64)
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> Acked-by: Michael Büsch <m@bues.ch>
Patch applied to wireless-drivers-next.git, thanks.
d3bb26868105 ssb: make array pwr_info_offset static const, makes object smaller
--
https://patchwork.kernel.org/patch/11135599/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2019-09-13 14:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-06 15:40 [PATCH] ssb: make array pwr_info_offset static const, makes object smaller Colin King
2019-09-09 17:53 ` Michael Büsch
2019-09-13 14:23 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190913142335.C25DF607F1@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=m@bues.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).