Re: [PATCH] staging: wilc1000: look for rtc_clk clock in spi mode

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3396 bytes --]

Hi,

I love your patch! Yet something to improve:

[auto build test ERROR on linus/master]
[cannot apply to v5.3 next-20190916]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Adham-Abozaeid-microchip-com/staging-wilc1000-look-for-rtc_clk-clock-in-spi-mode/20190917-033844
config: c6x-allyesconfig (attached as .config)
compiler: c6x-elf-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=c6x 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/staging/wilc1000/wilc_spi.c: In function 'wilc_bus_probe':
>> drivers/staging/wilc1000/wilc_spi.c:136:6: error: 'struct wilc' has no member named 'rtc_clk'
     wilc->rtc_clk = devm_clk_get(&spi->dev, "rtc_clk");
         ^~
   drivers/staging/wilc1000/wilc_spi.c:137:26: error: 'struct wilc' has no member named 'rtc_clk'
     if (PTR_ERR_OR_ZERO(wilc->rtc_clk) == -EPROBE_DEFER)
                             ^~
   drivers/staging/wilc1000/wilc_spi.c:139:23: error: 'struct wilc' has no member named 'rtc_clk'
     else if (!IS_ERR(wilc->rtc_clk))
                          ^~
   drivers/staging/wilc1000/wilc_spi.c:140:26: error: 'struct wilc' has no member named 'rtc_clk'
      clk_prepare_enable(wilc->rtc_clk);
                             ^~
   drivers/staging/wilc1000/wilc_spi.c: In function 'wilc_bus_remove':
   drivers/staging/wilc1000/wilc_spi.c:153:18: error: 'struct wilc' has no member named 'rtc_clk'
     if (!IS_ERR(wilc->rtc_clk))
                     ^~
   drivers/staging/wilc1000/wilc_spi.c:154:29: error: 'struct wilc' has no member named 'rtc_clk'
      clk_disable_unprepare(wilc->rtc_clk);
                                ^~

vim +136 drivers/staging/wilc1000/wilc_spi.c

   105	
   106	static int wilc_bus_probe(struct spi_device *spi)
   107	{
   108		int ret;
   109		struct wilc *wilc;
   110		struct gpio_desc *gpio;
   111		struct wilc_spi *spi_priv;
   112	
   113		spi_priv = kzalloc(sizeof(*spi_priv), GFP_KERNEL);
   114		if (!spi_priv)
   115			return -ENOMEM;
   116	
   117		gpio = gpiod_get(&spi->dev, "irq", GPIOD_IN);
   118		if (IS_ERR(gpio)) {
   119			/* get the GPIO descriptor from hardcode GPIO number */
   120			gpio = gpio_to_desc(GPIO_NUM);
   121			if (!gpio)
   122				dev_err(&spi->dev, "failed to get the irq gpio\n");
   123		}
   124	
   125		ret = wilc_cfg80211_init(&wilc, &spi->dev, WILC_HIF_SPI, &wilc_hif_spi);
   126		if (ret) {
   127			kfree(spi_priv);
   128			return ret;
   129		}
   130	
   131		spi_set_drvdata(spi, wilc);
   132		wilc->dev = &spi->dev;
   133		wilc->bus_data = spi_priv;
   134		wilc->gpio_irq = gpio;
   135	
 > 136		wilc->rtc_clk = devm_clk_get(&spi->dev, "rtc_clk");
   137		if (PTR_ERR_OR_ZERO(wilc->rtc_clk) == -EPROBE_DEFER)
   138			return -EPROBE_DEFER;
   139		else if (!IS_ERR(wilc->rtc_clk))
   140			clk_prepare_enable(wilc->rtc_clk);
   141	
   142		return 0;
   143	}
   144	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 49705 bytes --]