From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37105ECE589 for ; Tue, 1 Oct 2019 11:19:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0F0DA21924 for ; Tue, 1 Oct 2019 11:19:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="VlXmjYoF"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="i/277xzR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731419AbfJALTO (ORCPT ); Tue, 1 Oct 2019 07:19:14 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:58570 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725900AbfJALTN (ORCPT ); Tue, 1 Oct 2019 07:19:13 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id A75D36014B; Tue, 1 Oct 2019 11:19:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1569928752; bh=TBrp107vqvrm5nw0Dhs+vhjDes58fG5CBnoGfgq8iXI=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=VlXmjYoFUICdyB08W+dyJtvJIibcEmbJeznAgp567xSEcSHFhVFqh4kgmyHKDFnZX aapgFOwWYW3SHtISGkJVVB3HA3/CAFoA3a4c3IfiDeOLvaYZUqpX/2pmEcEVxh+h1X mK63UvmTF4CAszgawXTW41g90305LNcpCQHdNRY8= Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 18BE8601D4; Tue, 1 Oct 2019 11:19:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1569928751; bh=TBrp107vqvrm5nw0Dhs+vhjDes58fG5CBnoGfgq8iXI=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=i/277xzREeUwLrLvgJRl7K3i3RaG8xSFWuw2pL4BELv8bKW64Bf5YlJiykvAyIN2v csY63r99jCRCIWjYLYKavWg0j2RJQXAiYWpsw1vnPrxjLI1vwT+3gWPfs2cknQKJKZ +fHDdkV/vJl4LcUyNEfncdNOZ7qKE1/u3eEjedxg= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 18BE8601D4 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] ath9k_hw: fix uninitialized variable data From: Kalle Valo In-Reply-To: <20190926225604.9342-1-efremov@linux.com> References: <20190926225604.9342-1-efremov@linux.com> To: Denis Efremov Cc: unlisted-recipients:; (no To-header on input) Denis Efremov , ath9k-devel@qca.qualcomm.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Rajkumar Manoharan , "John W . Linville" , "David S. Miller" , stable@vger.kernel.org Illegal-Object: Syntax error in Cc: address found on vger.kernel.org: Cc: unlisted-recipients:; (no To-header on input)Denis Efremov ^-missing end of address User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20191001111912.A75D36014B@smtp.codeaurora.org> Date: Tue, 1 Oct 2019 11:19:12 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Denis Efremov wrote: > Currently, data variable in ar9003_hw_thermo_cal_apply() could be > uninitialized if ar9300_otp_read_word() will fail to read the value. > Initialize data variable with 0 to prevent an undefined behavior. This > will be enough to handle error case when ar9300_otp_read_word() fails. > > Fixes: 80fe43f2bbd5 ("ath9k_hw: Read and configure thermocal for AR9462") > Cc: Rajkumar Manoharan > Cc: John W. Linville > Cc: Kalle Valo > Cc: "David S. Miller" > Cc: stable@vger.kernel.org > Signed-off-by: Denis Efremov > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 80e84f36412e ath9k_hw: fix uninitialized variable data -- https://patchwork.kernel.org/patch/11163437/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches