From: Kalle Valo <kvalo@codeaurora.org>
To: zhengbin <zhengbin13@huawei.com>
Cc: <pkshih@realtek.com>, <davem@davemloft.net>,
<linux-wireless@vger.kernel.org>, <netdev@vger.kernel.org>,
<zhengbin13@huawei.com>
Subject: Re: [PATCH 3/6] rtlwifi: rtl8192ee: Remove set but not used variable 'err'
Date: Wed, 2 Oct 2019 04:26:05 +0000 (UTC) [thread overview]
Message-ID: <20191002042605.529B0601E7@smtp.codeaurora.org> (raw)
In-Reply-To: <1569833692-93288-4-git-send-email-zhengbin13@huawei.com>
zhengbin <zhengbin13@huawei.com> wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c: In function rtl92ee_download_fw:
> drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c:111:6: warning: variable err set but not used [-Wunused-but-set-variable]
>
> It is not used since commit c93ac39da006 ("rtlwifi:
> Remove some redundant code")
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: zhengbin <zhengbin13@huawei.com>
Dropping this patch per Ping's comment, please fix and resend this
patch.
Patch set to Changes Requested.
--
https://patchwork.kernel.org/patch/11166207/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2019-10-02 4:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-30 8:54 [PATCH 0/6] rtlwifi: Remove a bunch of set but not used variables zhengbin
2019-09-30 8:54 ` [PATCH 1/6] rtlwifi: Remove set but not used variable 'rtstate' zhengbin
2019-10-02 4:33 ` Kalle Valo
2019-09-30 8:54 ` [PATCH 2/6] rtlwifi: Remove set but not used variables 'dataempty','hoffset' zhengbin
2019-09-30 8:54 ` [PATCH 3/6] rtlwifi: rtl8192ee: Remove set but not used variable 'err' zhengbin
2019-10-01 9:38 ` Pkshih
2019-10-02 4:26 ` Kalle Valo [this message]
2019-09-30 8:54 ` [PATCH 4/6] rtlwifi: rtl8192ee: Remove set but not used variables 'short_gi','buf_len' zhengbin
2019-09-30 8:54 ` [PATCH 5/6] rtlwifi: rtl8192ee: Remove set but not used variables 'reg_ecc','reg_eac' zhengbin
2019-09-30 8:54 ` [PATCH 6/6] rtlwifi: rtl8723be: " zhengbin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191002042605.529B0601E7@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=davem@davemloft.net \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pkshih@realtek.com \
--cc=zhengbin13@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).