* [PATCH] net: wireless: rtlwifi: rtl8192c:Drop condition with no effect
@ 2019-10-28 18:46 Saurav Girepunje
2019-10-29 15:07 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Saurav Girepunje @ 2019-10-28 18:46 UTC (permalink / raw)
To: pkshih, kvalo, davem, Larry.Finger, saurav.girepunje,
linux-wireless, netdev, linux-kernel
Cc: saurav.girepunje
As the "else if" and "else" branch body are identical the condition
has no effect. So drop the "else if" condition.
Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
---
drivers/net/wireless/realtek/rtlwifi/rtl8192c/dm_common.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192c/dm_common.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192c/dm_common.c
index f2908ee5f860..4bef237f488d 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8192c/dm_common.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192c/dm_common.c
@@ -1649,8 +1649,6 @@ static void rtl92c_bt_ant_isolation(struct ieee80211_hw *hw, u8 tmp1byte)
(rtlpriv->btcoexist.bt_rssi_state &
BT_RSSI_STATE_SPECIAL_LOW)) {
rtl_write_byte(rtlpriv, REG_GPIO_MUXCFG, 0xa0);
- } else if (rtlpriv->btcoexist.bt_service == BT_PAN) {
- rtl_write_byte(rtlpriv, REG_GPIO_MUXCFG, tmp1byte);
} else {
rtl_write_byte(rtlpriv, REG_GPIO_MUXCFG, tmp1byte);
}
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: wireless: rtlwifi: rtl8192c:Drop condition with no effect
2019-10-28 18:46 [PATCH] net: wireless: rtlwifi: rtl8192c:Drop condition with no effect Saurav Girepunje
@ 2019-10-29 15:07 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2019-10-29 15:07 UTC (permalink / raw)
To: Saurav Girepunje
Cc: pkshih, davem, Larry.Finger, linux-wireless, netdev, linux-kernel,
saurav.girepunje
Saurav Girepunje <saurav.girepunje@gmail.com> writes:
> As the "else if" and "else" branch body are identical the condition
> has no effect. So drop the "else if" condition.
>
> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
Thanks, I see these patches in patchwork now.
But then you submit a new version of a patch, please mark it as "[PATCH v2]":
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#patch_version_missing
This is for future submissions, no need to resend because of this.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-29 15:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-28 18:46 [PATCH] net: wireless: rtlwifi: rtl8192c:Drop condition with no effect Saurav Girepunje
2019-10-29 15:07 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).