From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Daniel Golle <daniel@makrotopia.org>
Cc: Tom Psyborg <pozega.tomislav@gmail.com>,
linux-wireless@vger.kernel.org, Roman Yeryomin <roman@advem.lv>,
wbob <wbob@jify.de>
Subject: Re: [PATCH] rt2800: remove erroneous duplicate condition
Date: Mon, 4 Nov 2019 10:15:26 +0100 [thread overview]
Message-ID: <20191104091525.GB2306@redhat.com> (raw)
In-Reply-To: <20191104090058.GA1258@makrotopia.org>
On Mon, Nov 04, 2019 at 10:00:58AM +0100, Daniel Golle wrote:
> On Mon, Nov 04, 2019 at 09:48:23AM +0100, Stanislaw Gruszka wrote:
> > On Sun, Nov 03, 2019 at 04:41:11PM +0100, Tom Psyborg wrote:
> > > On 03/11/2019, Stanislaw Gruszka <sgruszka@redhat.com> wrote:
> > > > On Sat, Nov 02, 2019 at 06:42:27PM +0100, Daniel Golle wrote:
> > > >> > This was changed by:
> > > >> >
> > > >> > commit c2e28ef7711ffcb083474ee5f154264c6ec1ec07
> > > >> > Author: Tomislav Požega <pozega.tomislav@gmail.com>
> > > >> > Date: Thu Dec 27 15:05:25 2018 +0100
> > > >> >
> > > >> > rt2x00: reduce tx power to nominal level on RT6352
> > > >> >
> > > >> > and I think it is correct.
> > > >>
> > > >> Ah, ok, that's a bit funny, because it means that this change actually
> > > >> never made any difference, because the codepath wasn't executed.
> > > >
> > > > Yes, this was used/tested on patched rt2x00 driver that switch to this
> > > > different codepath. Now it will be used by default :-)
> > > >
> > > > Stanislaw
> > > >
> > > >
> > >
> > > Hi
> > >
> > > For your reference: rt2x00: reduce tx power to nominal level on RT6352
> > >
> > > iPA/eLNA - fixes too high power output
> > > ePA/eLNA - doesn't have any effect
> > > iPA/iLNA - not tested
> >
> > Does someone have iPA/iLNA device so this can be tested?
> > Or it is not used combination on available devices?
>
> iPA/iLNA the most commonly found combination in cheap devices.
> iPA/eLNA is more rare, but found in some higher-quality devices.
> ePA/eLNA is available mostly in markets which allow higher TX power.
> ePA/iLNA haven't seen it yet, but theoretically possible.
>
> Looking at the internal photos of Nexx WT3020, I'm very certain this
> is an iPA/iLNA device -- apart from regulators, magnetics, MT7620N
> itself and flash memory, another magnetics and RAM on the backside,
> there are no other parts on the board. Also afaik MT7620N only supports
> iLNA/iPA (due to the limited number of pins of the DRQFN package).
With the change on WT3020 I observed better RX throughput and more
or less the same TX throughput. Not sure why, since the settings
is about TX? I'll do more test, but so far Tom's change looks like
good improvment for me.
> See:
> https://apps.fcc.gov/eas/GetApplicationAttachment.html?id=2241504
I get 'You are not authorized to access this page.' :-/
Stanislaw
next prev parent reply other threads:[~2019-11-04 9:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-28 21:22 [PATCH] rt2800: remove erroneous duplicate condition Daniel Golle
2019-10-29 9:18 ` Stanislaw Gruszka
2019-10-29 10:05 ` Daniel Golle
2019-11-02 15:46 ` Stanislaw Gruszka
2019-11-02 17:42 ` Daniel Golle
2019-11-03 14:47 ` Stanislaw Gruszka
2019-11-03 15:41 ` Tom Psyborg
2019-11-04 8:48 ` Stanislaw Gruszka
2019-11-04 9:00 ` Daniel Golle
2019-11-04 9:15 ` Stanislaw Gruszka [this message]
2019-11-04 13:48 ` Daniel Golle
2019-11-11 11:00 ` Stanislaw Gruszka
2019-11-04 11:48 ` Tom Psyborg
2019-11-02 17:47 ` [PATCH v2] rt2800: remove errornous " Daniel Golle
2019-11-03 14:48 ` Stanislaw Gruszka
2019-11-06 17:57 ` Kalle Valo
-- strict thread matches above, loose matches on Subject: below --
2019-10-28 21:20 [PATCH] rt2800: remove erroneous " Daniel Golle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191104091525.GB2306@redhat.com \
--to=sgruszka@redhat.com \
--cc=daniel@makrotopia.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pozega.tomislav@gmail.com \
--cc=roman@advem.lv \
--cc=wbob@jify.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).