From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: linux-wireless@vger.kernel.org, Felix Fietkau <nbd@nbd.name>,
Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>,
Ryder Lee <ryder.lee@mediatek.com>, Roy Luo <royluo@google.com>
Subject: Re: [PATCH] Revert "mt76: mt76x0e: don't use hw encryption for MT7630E"
Date: Mon, 4 Nov 2019 12:03:37 +0200 [thread overview]
Message-ID: <20191104100337.GC3935@localhost.localdomain> (raw)
In-Reply-To: <1572860780-2403-1-git-send-email-sgruszka@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 2007 bytes --]
> This reverts commit 34b0e9b767bfa09ae233ca0d6ceb299bf2e24600.
>
> Since 7bd0650be63c ("mt76: dma: fix buffer unmap with non-linear skbs")
> is no longer necessary to disable HW encryption for MT7630E.
>
> Disabling HW encryption helped previously because somehow fragmented
> skb's are not created if mac80211 encrypt frames, so buffer unmap bug
> of non-linear skbs was not triggered. Now since this bug if properly
> fixed by 7bd0650be63c , we can enable HW encryption back.
>
> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
> ---
> drivers/net/wireless/mediatek/mt76/mt76x0/pci.c | 15 +--------------
> 1 file changed, 1 insertion(+), 14 deletions(-)
Acked-by: Lorenzo Bianconi <lorenzo@kernel.org>
>
> diff --git a/drivers/net/wireless/mediatek/mt76/mt76x0/pci.c b/drivers/net/wireless/mediatek/mt76/mt76x0/pci.c
> index 7705e55aa3d1..f84a7df296ea 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt76x0/pci.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt76x0/pci.c
> @@ -51,19 +51,6 @@ static void mt76x0e_stop(struct ieee80211_hw *hw)
> mt76x0e_stop_hw(dev);
> }
>
> -static int
> -mt76x0e_set_key(struct ieee80211_hw *hw, enum set_key_cmd cmd,
> - struct ieee80211_vif *vif, struct ieee80211_sta *sta,
> - struct ieee80211_key_conf *key)
> -{
> - struct mt76x02_dev *dev = hw->priv;
> -
> - if (is_mt7630(dev))
> - return -EOPNOTSUPP;
> -
> - return mt76x02_set_key(hw, cmd, vif, sta, key);
> -}
> -
> static void
> mt76x0e_flush(struct ieee80211_hw *hw, struct ieee80211_vif *vif,
> u32 queues, bool drop)
> @@ -80,7 +67,7 @@ static void mt76x0e_stop(struct ieee80211_hw *hw)
> .configure_filter = mt76x02_configure_filter,
> .bss_info_changed = mt76x02_bss_info_changed,
> .sta_state = mt76_sta_state,
> - .set_key = mt76x0e_set_key,
> + .set_key = mt76x02_set_key,
> .conf_tx = mt76x02_conf_tx,
> .sw_scan_start = mt76_sw_scan,
> .sw_scan_complete = mt76x02_sw_scan_complete,
> --
> 1.9.3
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2019-11-04 10:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-04 9:46 [PATCH] Revert "mt76: mt76x0e: don't use hw encryption for MT7630E" Stanislaw Gruszka
2019-11-04 10:03 ` Lorenzo Bianconi [this message]
2019-11-05 8:21 ` Kalle Valo
2019-11-05 9:00 ` Stanislaw Gruszka
2019-11-05 9:08 ` Petr Štetiar
2019-11-05 9:52 ` Stanislaw Gruszka
2019-11-05 14:06 ` Kalle Valo
2019-11-05 9:13 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191104100337.GC3935@localhost.localdomain \
--to=lorenzo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi83@gmail.com \
--cc=nbd@nbd.name \
--cc=royluo@google.com \
--cc=ryder.lee@mediatek.com \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).