From: Stanislaw Gruszka <sgruszka@redhat.com>
To: "Petr Štetiar" <ynezz@true.cz>
Cc: Kalle Valo <kvalo@codeaurora.org>,
linux-wireless@vger.kernel.org, Felix Fietkau <nbd@nbd.name>,
Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>,
Ryder Lee <ryder.lee@mediatek.com>, Roy Luo <royluo@google.com>
Subject: Re: [PATCH] Revert "mt76: mt76x0e: don't use hw encryption for MT7630E"
Date: Tue, 5 Nov 2019 10:52:27 +0100 [thread overview]
Message-ID: <20191105095226.GC4422@redhat.com> (raw)
In-Reply-To: <20191105090845.GP22393@meh.true.cz>
On Tue, Nov 05, 2019 at 10:08:45AM +0100, Petr Štetiar wrote:
> Stanislaw Gruszka <sgruszka@redhat.com> [2019-11-05 10:00:44]:
>
> Hi,
>
> > I provided the topic in the first reference of the commit at the top.
> > Should I do this anytime in the chenglog when a commit is referenced,
> > even if it's done already ?
>
> ./scripts/checkpatch.pl 0001-Revert-mt76-mt76x0e-don-t-use-hw-encryption-for-MT76.patch
> ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 7bd0650be63c ("mt76: dma: fix buffer unmap with non-linear skbs")'
> #8:
> Since 7bd0650be63c ("mt76: dma: fix buffer unmap with non-linear skbs")
Okay, so I should add word 'commit' before HASH.
> ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 7bd0650be63c ("mt76: dma: fix buffer unmap with non-linear skbs")'
> #14:
> fixed by 7bd0650be63c , we can enable HW encryption back.
It's not clear if topic is need, but I can change it on the way.
BTW I hate checkpath.pl .
Stanislaw
next prev parent reply other threads:[~2019-11-05 9:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-04 9:46 [PATCH] Revert "mt76: mt76x0e: don't use hw encryption for MT7630E" Stanislaw Gruszka
2019-11-04 10:03 ` Lorenzo Bianconi
2019-11-05 8:21 ` Kalle Valo
2019-11-05 9:00 ` Stanislaw Gruszka
2019-11-05 9:08 ` Petr Štetiar
2019-11-05 9:52 ` Stanislaw Gruszka [this message]
2019-11-05 14:06 ` Kalle Valo
2019-11-05 9:13 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191105095226.GC4422@redhat.com \
--to=sgruszka@redhat.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi83@gmail.com \
--cc=nbd@nbd.name \
--cc=royluo@google.com \
--cc=ryder.lee@mediatek.com \
--cc=ynezz@true.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).