* [PATCH] crda: Makefile: fix .so compilation line with some compilers
@ 2019-11-05 22:57 Brian Norris
2019-11-05 23:02 ` Brian Norris
0 siblings, 1 reply; 7+ messages in thread
From: Brian Norris @ 2019-11-05 22:57 UTC (permalink / raw)
To: linux-wireless, wireless-regdb; +Cc: Brian Norris
Write the CC rule such that it only tries to produce a single output
file (the .so). When including the .h files in the compiler invocation,
this suggests we should be producing pre-compiled headers too, which
doesn't make sense in this context, and Clang happens not to like.
Signed-off-by: Brian Norris <briannorris@chromium.org>
---
Yes, I know CRDA is deprecated.
Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index 6169b1f307da..6ca26f341dfa 100644
--- a/Makefile
+++ b/Makefile
@@ -114,9 +114,9 @@ keys-%.c: utils/key2pub.py $(wildcard $(PUBKEY_DIR)/*.pem)
$(NQ) ' Trusted pubkeys:' $(wildcard $(PUBKEY_DIR)/*.pem)
$(Q)./utils/key2pub.py --$* $(wildcard $(PUBKEY_DIR)/*.pem) $@
-$(LIBREG): regdb.h reglib.h reglib.c
+$(LIBREG): reglib.c regdb.h reglib.h
$(NQ) ' CC ' $@
- $(Q)$(CC) $(CFLAGS) $(CPPFLAGS) -o $@ -shared -Wl,-soname,$(LIBREG) $^
+ $(Q)$(CC) $(CFLAGS) $(CPPFLAGS) -o $@ -shared -Wl,-soname,$(LIBREG) $<
install-libreg-headers:
$(NQ) ' INSTALL libreg-headers'
--
2.24.0.rc1.363.gb1bccd3e3d-goog
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] crda: Makefile: fix .so compilation line with some compilers
2019-11-05 22:57 [PATCH] crda: Makefile: fix .so compilation line with some compilers Brian Norris
@ 2019-11-05 23:02 ` Brian Norris
2019-11-06 8:12 ` Johannes Berg
0 siblings, 1 reply; 7+ messages in thread
From: Brian Norris @ 2019-11-05 23:02 UTC (permalink / raw)
To: linux-wireless, wireless-regdb
On Tue, Nov 5, 2019 at 2:57 PM Brian Norris <briannorris@chromium.org> wrote:
>
> Write the CC rule such that it only tries to produce a single output
> file (the .so). When including the .h files in the compiler invocation,
> this suggests we should be producing pre-compiled headers too, which
> doesn't make sense in this context, and Clang happens not to like.
>
> Signed-off-by: Brian Norris <briannorris@chromium.org>
> ---
Apparently wireless-regdb@ is subscribers only. I have since joined,
but I guess my patch bounced from that list... if I don't hear back in
a while, I may resend.
Brian
> Yes, I know CRDA is deprecated.
>
> Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 6169b1f307da..6ca26f341dfa 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -114,9 +114,9 @@ keys-%.c: utils/key2pub.py $(wildcard $(PUBKEY_DIR)/*.pem)
> $(NQ) ' Trusted pubkeys:' $(wildcard $(PUBKEY_DIR)/*.pem)
> $(Q)./utils/key2pub.py --$* $(wildcard $(PUBKEY_DIR)/*.pem) $@
>
> -$(LIBREG): regdb.h reglib.h reglib.c
> +$(LIBREG): reglib.c regdb.h reglib.h
> $(NQ) ' CC ' $@
> - $(Q)$(CC) $(CFLAGS) $(CPPFLAGS) -o $@ -shared -Wl,-soname,$(LIBREG) $^
> + $(Q)$(CC) $(CFLAGS) $(CPPFLAGS) -o $@ -shared -Wl,-soname,$(LIBREG) $<
>
> install-libreg-headers:
> $(NQ) ' INSTALL libreg-headers'
> --
> 2.24.0.rc1.363.gb1bccd3e3d-goog
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] crda: Makefile: fix .so compilation line with some compilers
2019-11-05 23:02 ` Brian Norris
@ 2019-11-06 8:12 ` Johannes Berg
2019-11-06 16:38 ` Brian Norris
0 siblings, 1 reply; 7+ messages in thread
From: Johannes Berg @ 2019-11-06 8:12 UTC (permalink / raw)
To: Brian Norris, linux-wireless, wireless-regdb
On Tue, 2019-11-05 at 15:02 -0800, Brian Norris wrote:
> On Tue, Nov 5, 2019 at 2:57 PM Brian Norris <briannorris@chromium.org> wrote:
> > Write the CC rule such that it only tries to produce a single output
> > file (the .so). When including the .h files in the compiler invocation,
> > this suggests we should be producing pre-compiled headers too, which
> > doesn't make sense in this context, and Clang happens not to like.
> >
> > Signed-off-by: Brian Norris <briannorris@chromium.org>
> > ---
>
> Apparently wireless-regdb@ is subscribers only. I have since joined,
> but I guess my patch bounced from that list... if I don't hear back in
> a while, I may resend.
The bigger question is who actually maintains crda now, if anyone ... :)
johannes
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] crda: Makefile: fix .so compilation line with some compilers
2019-11-06 8:12 ` Johannes Berg
@ 2019-11-06 16:38 ` Brian Norris
2019-11-06 23:17 ` Luis Chamberlain
0 siblings, 1 reply; 7+ messages in thread
From: Brian Norris @ 2019-11-06 16:38 UTC (permalink / raw)
To: Johannes Berg; +Cc: linux-wireless, wireless-regdb, mcgrof
On Wed, Nov 6, 2019 at 12:12 AM Johannes Berg <johannes@sipsolutions.net> wrote:
> On Tue, 2019-11-05 at 15:02 -0800, Brian Norris wrote:
> > Apparently wireless-regdb@ is subscribers only. I have since joined,
> > but I guess my patch bounced from that list... if I don't hear back in
> > a while, I may resend.
>
> The bigger question is who actually maintains crda now, if anyone ... :)
My mailbox tells me that as of about a year ago, Luis was still
merging patches. And his latest commit even claims it's "still
maintained":
As if kernel v4.15 CRDA is no longer needed. Annotate this. The
code will still be maintained to help older kernels.
Brian
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] crda: Makefile: fix .so compilation line with some compilers
2019-11-06 16:38 ` Brian Norris
@ 2019-11-06 23:17 ` Luis Chamberlain
2019-11-07 17:37 ` [RESEND PATCH] " Brian Norris
0 siblings, 1 reply; 7+ messages in thread
From: Luis Chamberlain @ 2019-11-06 23:17 UTC (permalink / raw)
To: Brian Norris; +Cc: Johannes Berg, linux-wireless, wireless-regdb
On Wed, Nov 06, 2019 at 08:38:33AM -0800, Brian Norris wrote:
> On Wed, Nov 6, 2019 at 12:12 AM Johannes Berg <johannes@sipsolutions.net> wrote:
> > On Tue, 2019-11-05 at 15:02 -0800, Brian Norris wrote:
> > > Apparently wireless-regdb@ is subscribers only. I have since joined,
> > > but I guess my patch bounced from that list... if I don't hear back in
> > > a while, I may resend.
> >
> > The bigger question is who actually maintains crda now, if anyone ... :)
>
> My mailbox tells me that as of about a year ago, Luis was still
> merging patches. And his latest commit even claims it's "still
> maintained":
>
> As if kernel v4.15 CRDA is no longer needed. Annotate this. The
> code will still be maintained to help older kernels.
Sure, send me patches. Its just not needed on older systems.
Luis
^ permalink raw reply [flat|nested] 7+ messages in thread
* [RESEND PATCH] crda: Makefile: fix .so compilation line with some compilers
2019-11-06 23:17 ` Luis Chamberlain
@ 2019-11-07 17:37 ` Brian Norris
2019-11-12 22:45 ` Luis Chamberlain
0 siblings, 1 reply; 7+ messages in thread
From: Brian Norris @ 2019-11-07 17:37 UTC (permalink / raw)
To: Luis Chamberlain; +Cc: Johannes Berg, linux-wireless, wireless-regdb
Write the CC rule such that it only tries to produce a single output
file (the .so). When including the .h files in the compiler invocation,
this suggests we should be producing pre-compiled headers too, which
doesn't make sense in this context, and Clang happens not to like.
Signed-off-by: Brian Norris <briannorris@chromium.org>
---
On Wed, Nov 06, 2019 at 11:17:49PM +0000, Luis Chamberlain wrote:
> Sure, send me patches.
Done.
Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index 6169b1f307da..6ca26f341dfa 100644
--- a/Makefile
+++ b/Makefile
@@ -114,9 +114,9 @@ keys-%.c: utils/key2pub.py $(wildcard $(PUBKEY_DIR)/*.pem)
$(NQ) ' Trusted pubkeys:' $(wildcard $(PUBKEY_DIR)/*.pem)
$(Q)./utils/key2pub.py --$* $(wildcard $(PUBKEY_DIR)/*.pem) $@
-$(LIBREG): regdb.h reglib.h reglib.c
+$(LIBREG): reglib.c regdb.h reglib.h
$(NQ) ' CC ' $@
- $(Q)$(CC) $(CFLAGS) $(CPPFLAGS) -o $@ -shared -Wl,-soname,$(LIBREG) $^
+ $(Q)$(CC) $(CFLAGS) $(CPPFLAGS) -o $@ -shared -Wl,-soname,$(LIBREG) $<
install-libreg-headers:
$(NQ) ' INSTALL libreg-headers'
--
2.24.0.rc1.363.gb1bccd3e3d-goog
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [RESEND PATCH] crda: Makefile: fix .so compilation line with some compilers
2019-11-07 17:37 ` [RESEND PATCH] " Brian Norris
@ 2019-11-12 22:45 ` Luis Chamberlain
0 siblings, 0 replies; 7+ messages in thread
From: Luis Chamberlain @ 2019-11-12 22:45 UTC (permalink / raw)
To: Brian Norris; +Cc: Johannes Berg, linux-wireless, wireless-regdb
On Thu, Nov 07, 2019 at 09:37:24AM -0800, Brian Norris wrote:
> Write the CC rule such that it only tries to produce a single output
> file (the .so). When including the .h files in the compiler invocation,
> this suggests we should be producing pre-compiled headers too, which
> doesn't make sense in this context, and Clang happens not to like.
>
> Signed-off-by: Brian Norris <briannorris@chromium.org>
> ---
> On Wed, Nov 06, 2019 at 11:17:49PM +0000, Luis Chamberlain wrote:
> > Sure, send me patches.
Thanks, applied and pushed!
Luis
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-11-12 22:45 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-11-05 22:57 [PATCH] crda: Makefile: fix .so compilation line with some compilers Brian Norris
2019-11-05 23:02 ` Brian Norris
2019-11-06 8:12 ` Johannes Berg
2019-11-06 16:38 ` Brian Norris
2019-11-06 23:17 ` Luis Chamberlain
2019-11-07 17:37 ` [RESEND PATCH] " Brian Norris
2019-11-12 22:45 ` Luis Chamberlain
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).