From: Kalle Valo <kvalo@codeaurora.org>
To: Luca Coelho <luca@coelho.fi>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v5.4 1/3] iwlwifi: pcie: don't consider IV len in A-MSDU
Date: Fri, 8 Nov 2019 19:37:27 +0000 (UTC) [thread overview]
Message-ID: <20191108193727.6906F61282@smtp.codeaurora.org> (raw)
In-Reply-To: <20191107115149.10709-1-luca@coelho.fi>
Luca Coelho <luca@coelho.fi> wrote:
> From: Mordechay Goodstein <mordechay.goodstein@intel.com>
>
> From gen2 PN is totally offloaded to hardware (also the space for the
> IV isn't part of the skb). As you can see in mvm/mac80211.c:3545, the
> MAC for cipher types CCMP/GCMP doesn't set
> IEEE80211_KEY_FLAG_PUT_IV_SPACE for gen2 NICs.
>
> This causes all the AMSDU data to be corrupted with cipher enabled.
>
> Signed-off-by: Mordechay Goodstein <mordechay.goodstein@intel.com>
> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
Patch applied to wireless-drivers.git, thanks.
cb1a4badf592 iwlwifi: pcie: don't consider IV len in A-MSDU
--
https://patchwork.kernel.org/patch/11232699/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2019-11-08 19:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-07 11:51 [PATCH v5.4 1/3] iwlwifi: pcie: don't consider IV len in A-MSDU Luca Coelho
2019-11-07 11:51 ` [PATCH v5.4 2/3] mac80211: fix ieee80211_txq_setup_flows() failure path Luca Coelho
2019-11-07 11:51 ` [PATCH v5.4 3/3] iwlwifi: check kasprintf() return value Luca Coelho
2019-11-07 13:27 ` Luca Coelho
2019-11-08 19:37 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191108193727.6906F61282@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luca@coelho.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).