From: Luis Chamberlain <mcgrof@kernel.org>
To: Brian Norris <briannorris@chromium.org>
Cc: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless <linux-wireless@vger.kernel.org>,
wireless-regdb@lists.infradead.org
Subject: Re: [RESEND PATCH] crda: Makefile: fix .so compilation line with some compilers
Date: Tue, 12 Nov 2019 22:45:26 +0000 [thread overview]
Message-ID: <20191112224526.GP11244@42.do-not-panic.com> (raw)
In-Reply-To: <20191107173723.GA157096@google.com>
On Thu, Nov 07, 2019 at 09:37:24AM -0800, Brian Norris wrote:
> Write the CC rule such that it only tries to produce a single output
> file (the .so). When including the .h files in the compiler invocation,
> this suggests we should be producing pre-compiled headers too, which
> doesn't make sense in this context, and Clang happens not to like.
>
> Signed-off-by: Brian Norris <briannorris@chromium.org>
> ---
> On Wed, Nov 06, 2019 at 11:17:49PM +0000, Luis Chamberlain wrote:
> > Sure, send me patches.
Thanks, applied and pushed!
Luis
prev parent reply other threads:[~2019-11-12 22:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-05 22:57 [PATCH] crda: Makefile: fix .so compilation line with some compilers Brian Norris
2019-11-05 23:02 ` Brian Norris
2019-11-06 8:12 ` Johannes Berg
2019-11-06 16:38 ` Brian Norris
2019-11-06 23:17 ` Luis Chamberlain
2019-11-07 17:37 ` [RESEND PATCH] " Brian Norris
2019-11-12 22:45 ` Luis Chamberlain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191112224526.GP11244@42.do-not-panic.com \
--to=mcgrof@kernel.org \
--cc=briannorris@chromium.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=wireless-regdb@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).