* [PATCH] ath10k: Revert "ath10k: add cleanup in ath10k_sta_state()"
@ 2019-11-13 20:26 Bjorn Andersson
2019-11-15 6:58 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Bjorn Andersson @ 2019-11-13 20:26 UTC (permalink / raw)
To: Kalle Valo, David S. Miller
Cc: ath10k, linux-wireless, netdev, linux-kernel, linux-arm-msm,
jeffrey.l.hugo, wenwen
'334f5b61a6f2 ("ath10k: add cleanup in ath10k_sta_state()")' causes
ath10k_snoc on Qualcomm MSM8998, SDM845 and QCS404 platforms to trigger
an assert in the firmware:
err_qdi.c:456:EF:wlan_process:1:cmnos_thread.c:3900:Asserted in wlan_vdev.c:_wlan_vdev_up:3219
Revert the offending commit for now.
This reverts commit 334f5b61a6f29834e881923b98d1e27e5ce9620d.
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
drivers/net/wireless/ath/ath10k/mac.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
index e8bdb2ba9b18..68f7d7246ef2 100644
--- a/drivers/net/wireless/ath/ath10k/mac.c
+++ b/drivers/net/wireless/ath/ath10k/mac.c
@@ -6638,12 +6638,8 @@ static int ath10k_sta_state(struct ieee80211_hw *hw,
spin_unlock_bh(&ar->data_lock);
- if (!sta->tdls) {
- ath10k_peer_delete(ar, arvif->vdev_id, sta->addr);
- ath10k_mac_dec_num_stations(arvif, sta);
- kfree(arsta->tx_stats);
+ if (!sta->tdls)
goto exit;
- }
ret = ath10k_wmi_update_fw_tdls_state(ar, arvif->vdev_id,
WMI_TDLS_ENABLE_ACTIVE);
--
2.23.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ath10k: Revert "ath10k: add cleanup in ath10k_sta_state()"
2019-11-13 20:26 [PATCH] ath10k: Revert "ath10k: add cleanup in ath10k_sta_state()" Bjorn Andersson
@ 2019-11-15 6:58 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2019-11-15 6:58 UTC (permalink / raw)
To: Bjorn Andersson
Cc: David S. Miller, ath10k, linux-wireless, netdev, linux-kernel,
linux-arm-msm, jeffrey.l.hugo, wenwen
Bjorn Andersson <bjorn.andersson@linaro.org> wrote:
> This reverts commit 334f5b61a6f29834e881923b98d1e27e5ce9620d.
>
> This caused ath10k_snoc on Qualcomm MSM8998, SDM845 and QCS404 platforms to
> trigger an assert in the firmware:
>
> err_qdi.c:456:EF:wlan_process:1:cmnos_thread.c:3900:Asserted in wlan_vdev.c:_wlan_vdev_up:3219
>
> Revert the offending commit for now.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
f4fe2e53349f ath10k: Revert "ath10k: add cleanup in ath10k_sta_state()"
--
https://patchwork.kernel.org/patch/11242743/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-15 6:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-11-13 20:26 [PATCH] ath10k: Revert "ath10k: add cleanup in ath10k_sta_state()" Bjorn Andersson
2019-11-15 6:58 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).