From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 308F1C432C0 for ; Mon, 18 Nov 2019 12:23:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 067B4206F4 for ; Mon, 18 Nov 2019 12:23:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574079807; bh=gxwTlq64h7VhmZoGB5MQmNhf+CwMtpyFwiLg1wuM8CE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=1qYnlNHyMrKa0xT02A54Sy9JqZwcicCQxk+a7mJmlx27xU1udiXOrxQakUru21cMs 07qDC+4CRU9NvNEL2Yoiqj6e6FZWx1LTl6y2vILPKBGvaQcGzSX4IS1d81EciDslBc 3I+Z0mntJ0v3FniDE9dlK2GxD3AtVLwKu8uVFDfU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726776AbfKRMX0 (ORCPT ); Mon, 18 Nov 2019 07:23:26 -0500 Received: from mail.kernel.org ([198.145.29.99]:48574 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726464AbfKRMXZ (ORCPT ); Mon, 18 Nov 2019 07:23:25 -0500 Received: from localhost.localdomain (unknown [77.139.212.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9B35020862; Mon, 18 Nov 2019 12:23:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574079804; bh=gxwTlq64h7VhmZoGB5MQmNhf+CwMtpyFwiLg1wuM8CE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Am7tpu4VUeq73di8nuaa7zbs91U3B5QAx+kyw/wIurSEhJkET7kRVqNKYda44HL3+ +DASar8WBLmd0ruSg/uwJdWRbWua1MOC0HpwVPQZl+dEJ5F5M8pBkv2nXyul4MMQx7 oMtcIWteLP+Ut9JZdPbDmL1xZiApNW+RdlHOLmDQ= Date: Mon, 18 Nov 2019 14:23:18 +0200 From: Lorenzo Bianconi To: Markus Theil Cc: nbd@nbd.name, linux-wireless@vger.kernel.org, lorenzo.bianconi@redhat.com, Stanislaw Gruszka Subject: Re: [PATCH v2 4/4] mt76: mt76x02: add channel switch support for usb interfaces Message-ID: <20191118122318.GB19790@localhost.localdomain> References: <20191118113907.9862-1-markus.theil@tu-ilmenau.de> <20191118113907.9862-5-markus.theil@tu-ilmenau.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7ZAtKRhVyVSsbBD2" Content-Disposition: inline In-Reply-To: <20191118113907.9862-5-markus.theil@tu-ilmenau.de> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org --7ZAtKRhVyVSsbBD2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > This patch enables channel switch support on mt76 usb interfaces. >=20 > Signed-off-by: Markus Theil > --- > drivers/net/wireless/mediatek/mt76/mt76x02_usb_core.c | 7 +++++++ > drivers/net/wireless/mediatek/mt76/mt76x02_util.c | 2 +- > drivers/net/wireless/mediatek/mt76/mt76x2/usb_main.c | 5 +++++ > 3 files changed, 13 insertions(+), 1 deletion(-) could you please fix following checkpatch error? Regards, Lorenzo ROR: open brace '{' following function definitions go on the next line #73: FILE: drivers/net/wireless/mediatek/mt76/mt76x2/usb_main.c:103: +static void mt76x2u_channel_switch_beacon(struct ieee80211_hw *hw, + struct ieee80211_vif *vif, + struct cfg80211_chan_def *chandef= ) {} > diff --git a/drivers/net/wireless/mediatek/mt76/mt76x02_usb_core.c b/driv= ers/net/wireless/mediatek/mt76/mt76x02_usb_core.c > index 8a2a90fb5663..891825043117 100644 > --- a/drivers/net/wireless/mediatek/mt76/mt76x02_usb_core.c > +++ b/drivers/net/wireless/mediatek/mt76/mt76x02_usb_core.c > @@ -182,6 +182,12 @@ static void mt76x02u_pre_tbtt_work(struct work_struc= t *work) > /* Prevent corrupt transmissions during update */ > mt76_set(dev, MT_BCN_BYPASS_MASK, 0xffff); > =20 > + mt76_csa_check(&dev->mt76); > + if (dev->mt76.csa_complete) { > + mt76_csa_finish(&dev->mt76); > + goto out; > + } > + > ieee80211_iterate_active_interfaces(mt76_hw(dev), > IEEE80211_IFACE_ITER_RESUME_ALL, > mt76x02_update_beacon_iter, dev); > @@ -196,6 +202,7 @@ static void mt76x02u_pre_tbtt_work(struct work_struct= *work) > =20 > mt76x02_mac_set_beacon_finish(dev); > =20 > +out: > mt76x02u_restart_pre_tbtt_timer(dev); > } > =20 > diff --git a/drivers/net/wireless/mediatek/mt76/mt76x02_util.c b/drivers/= net/wireless/mediatek/mt76/mt76x02_util.c > index 414b22399d93..3f95e5b24e1d 100644 > --- a/drivers/net/wireless/mediatek/mt76/mt76x02_util.c > +++ b/drivers/net/wireless/mediatek/mt76/mt76x02_util.c > @@ -174,7 +174,6 @@ void mt76x02_init_device(struct mt76x02_dev *dev) > wiphy->reg_notifier =3D mt76x02_regd_notifier; > wiphy->iface_combinations =3D mt76x02_if_comb; > wiphy->n_iface_combinations =3D ARRAY_SIZE(mt76x02_if_comb); > - wiphy->flags |=3D WIPHY_FLAG_HAS_CHANNEL_SWITCH; > =20 > /* init led callbacks */ > if (IS_ENABLED(CONFIG_MT76_LEDS)) { > @@ -184,6 +183,7 @@ void mt76x02_init_device(struct mt76x02_dev *dev) > } > } > =20 > + wiphy->flags |=3D WIPHY_FLAG_HAS_CHANNEL_SWITCH; > wiphy_ext_feature_set(wiphy, NL80211_EXT_FEATURE_VHT_IBSS); > =20 > hw->sta_data_size =3D sizeof(struct mt76x02_sta); > diff --git a/drivers/net/wireless/mediatek/mt76/mt76x2/usb_main.c b/drive= rs/net/wireless/mediatek/mt76/mt76x2/usb_main.c > index eb73cb856c81..ae576b29c9ac 100644 > --- a/drivers/net/wireless/mediatek/mt76/mt76x2/usb_main.c > +++ b/drivers/net/wireless/mediatek/mt76/mt76x2/usb_main.c > @@ -100,6 +100,10 @@ mt76x2u_config(struct ieee80211_hw *hw, u32 changed) > return err; > } > =20 > +static void mt76x2u_channel_switch_beacon(struct ieee80211_hw *hw, > + struct ieee80211_vif *vif, > + struct cfg80211_chan_def *chandef) {} > + > const struct ieee80211_ops mt76x2u_ops =3D { > .tx =3D mt76x02_tx, > .start =3D mt76x2u_start, > @@ -121,4 +125,5 @@ const struct ieee80211_ops mt76x2u_ops =3D { > .get_survey =3D mt76_get_survey, > .set_tim =3D mt76_set_tim, > .release_buffered_frames =3D mt76_release_buffered_frames, > + .channel_switch_beacon =3D mt76x2u_channel_switch_beacon, > }; > --=20 > 2.24.0 >=20 --7ZAtKRhVyVSsbBD2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCXdKNMwAKCRA6cBh0uS2t rF0XAP9wlFnXvUBvGoa5AugwLZ5v1bURO/2DFO1NGUaCHOvgcQD/Z3mLrFTL98+3 Mh+/3FsfDU2sx0U4JZD07j2RSstFpAo= =4aEL -----END PGP SIGNATURE----- --7ZAtKRhVyVSsbBD2--