From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Markus Theil <markus.theil@tu-ilmenau.de>
Cc: nbd@nbd.name, linux-wireless@vger.kernel.org,
lorenzo.bianconi@redhat.com
Subject: Re: [PATCH v4 4/4] mt76: mt76x02: add channel switch support for usb interfaces
Date: Tue, 19 Nov 2019 12:19:27 +0100 [thread overview]
Message-ID: <20191119111927.GB22415@redhat.com> (raw)
In-Reply-To: <20191118221540.14886-5-markus.theil@tu-ilmenau.de>
On Mon, Nov 18, 2019 at 11:15:40PM +0100, Markus Theil wrote:
> +static void mt76x2u_channel_switch_beacon(struct ieee80211_hw *hw,
> + struct ieee80211_vif *vif,
> + struct cfg80211_chan_def *chandef)
> +{
> +}
> +
> const struct ieee80211_ops mt76x2u_ops = {
> .tx = mt76x02_tx,
> .start = mt76x2u_start,
> @@ -121,4 +127,5 @@ const struct ieee80211_ops mt76x2u_ops = {
> .get_survey = mt76_get_survey,
> .set_tim = mt76_set_tim,
> .release_buffered_frames = mt76_release_buffered_frames,
> + .channel_switch_beacon = mt76x2u_channel_switch_beacon,
Is this needed ? Seems mac80211 check against this op being NULL
in drv_channel_switch_beacon() and it is not used otherwise.
Stanislaw
next prev parent reply other threads:[~2019-11-19 11:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-18 22:15 [PATCH v4 0/4] mt76: channel switch support for USB devices Markus Theil
2019-11-18 22:15 ` [PATCH v4 1/4] mt76: mt76x02: ommit beacon slot clearing Markus Theil
2019-11-18 22:15 ` [PATCH v4 2/4] mt76: mt76x02: split beaconing Markus Theil
2019-11-18 22:15 ` [PATCH v4 3/4] mt76: speed up usb bulk copy Markus Theil
2019-11-19 12:15 ` Lorenzo Bianconi
2019-11-19 12:27 ` Markus Theil
2019-11-18 22:15 ` [PATCH v4 4/4] mt76: mt76x02: add channel switch support for usb interfaces Markus Theil
2019-11-19 11:19 ` Stanislaw Gruszka [this message]
2019-11-19 12:12 ` Markus Theil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191119111927.GB22415@redhat.com \
--to=sgruszka@redhat.com \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=markus.theil@tu-ilmenau.de \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox