From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Felix Fietkau <nbd@nbd.name>
Cc: linux-wireless@vger.kernel.org, lorenzo.bianconi@redhat.com,
ryder.lee@mediatek.com, royluo@google.com
Subject: Re: [PATCH 2/3] mt76: move coverage_class and slottime in mt76_dev
Date: Wed, 20 Nov 2019 13:42:26 +0200 [thread overview]
Message-ID: <20191120114226.GB21993@localhost.localdomain> (raw)
In-Reply-To: <90b792b4-98d0-accc-057d-9f1bb9cfbbb5@nbd.name>
[-- Attachment #1: Type: text/plain, Size: 820 bytes --]
> On 2019-11-15 16:05, Lorenzo Bianconi wrote:
> > Move coverage_class and slottime fields from driver specific data
> > structure to mt76_dev since they are used by all drivers
> >
> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> Please drop this patch. I've moved a few other fields back from struct
> mt76_dev to driver specific structs, because they were in the way of
> DBDC related rework, and this one would fit the category too.
>
> As a general policy, I think we should only move fields to struct
> mt76_dev if they are actually used by core code as well.
ack, let's drop this patch. In the future we will need to integrate the timeing
code in DBDC one since mt7615 has related regs for band0 and band1. Maybe we need
to move them in mt76_phy?
Regards,
Lorenzo
>
> - Felix
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2019-11-20 11:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-15 15:05 [PATCH 0/3] add set_coverage support to mt7615 driver Lorenzo Bianconi
2019-11-15 15:05 ` [PATCH 1/3] mt76: mt76x02: fix coverage_class type Lorenzo Bianconi
2019-11-20 11:24 ` Felix Fietkau
2019-11-20 11:37 ` Lorenzo Bianconi
2019-11-15 15:05 ` [PATCH 2/3] mt76: move coverage_class and slottime in mt76_dev Lorenzo Bianconi
2019-11-20 11:20 ` Felix Fietkau
2019-11-20 11:42 ` Lorenzo Bianconi [this message]
2019-11-20 11:44 ` Felix Fietkau
2019-11-15 15:05 ` [PATCH 3/3] mt76: mt7615: add set_coverage class support Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191120114226.GB21993@localhost.localdomain \
--to=lorenzo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=nbd@nbd.name \
--cc=royluo@google.com \
--cc=ryder.lee@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).