From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68DAFC432C0 for ; Wed, 20 Nov 2019 11:42:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 392E522419 for ; Wed, 20 Nov 2019 11:42:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574250155; bh=GY0MZx2LrAzonJ3zzCRRnSJO+67emHCkJEh6MeR1ylw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=p5aKZ9foz3VXMbKUULzQcoSZ+Vl1VSuX3DPUgz5vv+btNudBJMt6AHsO2hTAAjZFK UKwAZbl007ij6qaoQjEbW5lqULq+lOhTnZutzh7dTfshk54woA+QhTv7jmSZnY/Itn 0SefimkKegMEbTixRVDOLHr54tcOSWmaoh6V/3tY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729239AbfKTLme (ORCPT ); Wed, 20 Nov 2019 06:42:34 -0500 Received: from mail.kernel.org ([198.145.29.99]:36200 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728343AbfKTLme (ORCPT ); Wed, 20 Nov 2019 06:42:34 -0500 Received: from localhost.localdomain (unknown [77.139.212.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CDF3F21906; Wed, 20 Nov 2019 11:42:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574250153; bh=GY0MZx2LrAzonJ3zzCRRnSJO+67emHCkJEh6MeR1ylw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Z7+nWj9DjNdJ1AxRV/7XGSX2vDYdSZ250UelK0KaXoo09hXs3b9BAJOwKibWin/gg BeQQNdCRe/NVBMDBFeenoc2Apc7nN9dRzxkZMZXuY8gGelS2FpyyDJ3dhobaySpPxu vwwMtUXNo7Fc/D2wa5de1LG5C6fiQry/of/VGlk0= Date: Wed, 20 Nov 2019 13:42:26 +0200 From: Lorenzo Bianconi To: Felix Fietkau Cc: linux-wireless@vger.kernel.org, lorenzo.bianconi@redhat.com, ryder.lee@mediatek.com, royluo@google.com Subject: Re: [PATCH 2/3] mt76: move coverage_class and slottime in mt76_dev Message-ID: <20191120114226.GB21993@localhost.localdomain> References: <90b792b4-98d0-accc-057d-9f1bb9cfbbb5@nbd.name> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="TakKZr9L6Hm6aLOc" Content-Disposition: inline In-Reply-To: <90b792b4-98d0-accc-057d-9f1bb9cfbbb5@nbd.name> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org --TakKZr9L6Hm6aLOc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > On 2019-11-15 16:05, Lorenzo Bianconi wrote: > > Move coverage_class and slottime fields from driver specific data > > structure to mt76_dev since they are used by all drivers > >=20 > > Signed-off-by: Lorenzo Bianconi > Please drop this patch. I've moved a few other fields back from struct > mt76_dev to driver specific structs, because they were in the way of > DBDC related rework, and this one would fit the category too. >=20 > As a general policy, I think we should only move fields to struct > mt76_dev if they are actually used by core code as well. ack, let's drop this patch. In the future we will need to integrate the tim= eing code in DBDC one since mt7615 has related regs for band0 and band1. Maybe w= e need to move them in mt76_phy? Regards, Lorenzo >=20 > - Felix --TakKZr9L6Hm6aLOc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCXdUmngAKCRA6cBh0uS2t rEZ9AP9nwPws6q/4tpFMEGH+jknnDNWXljLTlgQDPFpKL3c+ZAD+I7yail41q+vy KxqjozWmCNWKDYs6YYzC0lnxgS+MbAI= =HiLt -----END PGP SIGNATURE----- --TakKZr9L6Hm6aLOc--