* [PATCH] iwlwifi: mvm: fix interface bringup on non-ACPI configs
@ 2019-11-21 7:48 Wang Xuerui
2020-06-08 6:02 ` Luciano Coelho
0 siblings, 1 reply; 2+ messages in thread
From: Wang Xuerui @ 2019-11-21 7:48 UTC (permalink / raw)
To: linux-wireless; +Cc: Wang Xuerui, Gil Adam, Luca Coelho
Previously the non-ACPI stub of iwl_mvm_ppag_init unconditionally
returned -ENOENT, that in turn blocked flow of iwl_mvm_up.
Take the precedent of iwl_mvm_sar_geo_init, make iwl_mvm_ppag_init no-op
on non-ACPI configs.
Fixes: 6ce1e5c0c207 ("iwlwifi: support per-platform antenna gain")
Cc: Gil Adam <gil.adam@intel.com>
Cc: Luca Coelho <luciano.coelho@intel.com>
Signed-off-by: Wang Xuerui <git@xen0n.name>
---
drivers/net/wireless/intel/iwlwifi/mvm/fw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c
index d9eb2b286438..04ac47b7cae9 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c
@@ -1169,7 +1169,7 @@ int iwl_mvm_ppag_send_cmd(struct iwl_mvm *mvm)
static int iwl_mvm_ppag_init(struct iwl_mvm *mvm)
{
- return -ENOENT;
+ return 0;
}
#endif /* CONFIG_ACPI */
--
2.21.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iwlwifi: mvm: fix interface bringup on non-ACPI configs
2019-11-21 7:48 [PATCH] iwlwifi: mvm: fix interface bringup on non-ACPI configs Wang Xuerui
@ 2020-06-08 6:02 ` Luciano Coelho
0 siblings, 0 replies; 2+ messages in thread
From: Luciano Coelho @ 2020-06-08 6:02 UTC (permalink / raw)
To: Wang Xuerui, linux-wireless; +Cc: Gil Adam
On Thu, 2019-11-21 at 15:48 +0800, Wang Xuerui wrote:
> Previously the non-ACPI stub of iwl_mvm_ppag_init unconditionally
> returned -ENOENT, that in turn blocked flow of iwl_mvm_up.
>
> Take the precedent of iwl_mvm_sar_geo_init, make iwl_mvm_ppag_init no-op
> on non-ACPI configs.
>
> Fixes: 6ce1e5c0c207 ("iwlwifi: support per-platform antenna gain")
> Cc: Gil Adam <gil.adam@intel.com>
> Cc: Luca Coelho <luciano.coelho@intel.com>
> Signed-off-by: Wang Xuerui <git@xen0n.name>
> ---
> drivers/net/wireless/intel/iwlwifi/mvm/fw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c
> index d9eb2b286438..04ac47b7cae9 100644
> --- a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c
> +++ b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c
> @@ -1169,7 +1169,7 @@ int iwl_mvm_ppag_send_cmd(struct iwl_mvm *mvm)
>
> static int iwl_mvm_ppag_init(struct iwl_mvm *mvm)
> {
> - return -ENOENT;
> + return 0;
> }
> #endif /* CONFIG_ACPI */
This was already fixed in another patch. Thanks anyway!
--
Cheers,
Luca.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-08 6:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-11-21 7:48 [PATCH] iwlwifi: mvm: fix interface bringup on non-ACPI configs Wang Xuerui
2020-06-08 6:02 ` Luciano Coelho
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).