From: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: Lorenzo Bianconi <lorenzo@kernel.org>,
nbd@nbd.name, linux-wireless@vger.kernel.org,
ryder.lee@mediatek.com, royluo@google.com
Subject: Re: [PATCH v2 3/3] mt76: mt7615: add set_coverage class support
Date: Thu, 21 Nov 2019 10:01:46 +0200 [thread overview]
Message-ID: <20191121080146.GA2720@localhost.localdomain> (raw)
In-Reply-To: <0101016e8cf84124-8768f5ae-dcbe-4941-abf9-e950e6e7cf34-000000@us-west-2.amazonses.com>
[-- Attachment #1: Type: text/plain, Size: 1300 bytes --]
> Lorenzo Bianconi <lorenzo@kernel.org> writes:
>
> >> Lorenzo Bianconi <lorenzo@kernel.org> writes:
> >>
> >> > Add the capability to configure actimeout for mt7615 driver. Moreover
> >>
> >> acktimeout?
> >
> > Hi Kalle,
> >
> > yes, it suppposed to be acktimeout
> >
> >>
> >> > configure slottime according to the value provided by mac80211
> >> >
> >> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> >>
> >> [...]
> >>
> >> > --- a/drivers/net/wireless/mediatek/mt76/mt7615/mac.c
> >> > +++ b/drivers/net/wireless/mediatek/mt76/mt7615/mac.c
> >> > @@ -60,6 +60,47 @@ void mt7615_mac_reset_counters(struct mt7615_dev *dev)
> >> > mt76_set(dev, MT_WF_RMAC_MIB_AIRTIME0, MT_WF_RMAC_MIB_RXTIME_CLR);
> >> > }
> >> >
> >> > +/* XXX: DBDC support */
> >> > +void mt7615_mac_set_timing(struct mt7615_dev *dev)
> >>
> >> Should this be "FIXME:"? Thought don't remember what style is used in
> >> mt76.
> >
> > actually for DBDC we used TODO.
>
> Even better.
>
> > Should I resend?
>
> No strong feelings from me, just wanted to point out while reviewing the
> pathces. Up to Felix :)
ack, both ways are fine for me.
Regards,
Lorenzo
>
> --
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2019-11-21 8:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 13:01 [PATCH v2 0/3] add set_coverage support to mt7615 driver Lorenzo Bianconi
2019-11-20 13:01 ` [PATCH v2 1/3] mt76: mt76x02: fix coverage_class type Lorenzo Bianconi
2019-11-20 13:01 ` [PATCH v2 2/3] mt76: mt7603: set 0 as min coverage_class value Lorenzo Bianconi
2019-11-20 13:01 ` [PATCH v2 3/3] mt76: mt7615: add set_coverage class support Lorenzo Bianconi
2019-11-21 6:57 ` Kalle Valo
2019-11-21 7:44 ` Lorenzo Bianconi
2019-11-21 7:58 ` Kalle Valo
[not found] ` <0101016e8cf84124-8768f5ae-dcbe-4941-abf9-e950e6e7cf34-000000@us-west-2.amazonses.com>
2019-11-21 8:01 ` Lorenzo Bianconi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191121080146.GA2720@localhost.localdomain \
--to=lorenzo.bianconi@redhat.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=nbd@nbd.name \
--cc=royluo@google.com \
--cc=ryder.lee@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox