From: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To: Markus Theil <markus.theil@tu-ilmenau.de>
Cc: nbd@nbd.name, linux-wireless@vger.kernel.org,
Stanislaw Gruszka <sgruszka@redhat.com>
Subject: Re: [PATCH v9 2/6] mt76: mt76x02: split beaconing
Date: Wed, 18 Dec 2019 10:37:33 +0100 [thread overview]
Message-ID: <20191218093733.GA13035@localhost.localdomain> (raw)
In-Reply-To: <20191126214704.27297-3-markus.theil@tu-ilmenau.de>
[-- Attachment #1: Type: text/plain, Size: 707 bytes --]
[...]
>
> @@ -244,19 +248,15 @@ static void mt76x02u_pre_tbtt_enable(struct mt76x02_dev *dev, bool en)
>
> static void mt76x02u_beacon_enable(struct mt76x02_dev *dev, bool en)
> {
> - int i;
> -
> if (WARN_ON_ONCE(!dev->mt76.beacon_int))
> return;
>
> if (en) {
> mt76x02u_start_pre_tbtt_timer(dev);
> } else {
> - /* Timer is already stopped, only clean up
> - * PS buffered frames if any.
> + /* Timer is already stopped,
> + * nothing else to do here.
> */
> - for (i = 0; i < N_BCN_SLOTS; i++)
> - mt76x02_mac_set_beacon(dev, i, NULL);
> }
I guess here you can get rid of 'else' branch
Regards,
Lorenzo
> }
>
> --
> 2.24.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2019-12-18 9:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-26 21:46 [PATCH v9 0/6] mt76: channel switch support for USB devices Markus Theil
2019-11-26 21:46 ` [PATCH v9 1/6] mt76: mt76x02: ommit beacon slot clearing Markus Theil
2019-11-26 21:47 ` [PATCH v9 2/6] mt76: mt76x02: split beaconing Markus Theil
2019-12-17 9:50 ` Lorenzo Bianconi
2019-12-18 9:37 ` Lorenzo Bianconi [this message]
2019-12-18 12:12 ` Markus Theil
2019-11-26 21:47 ` [PATCH v9 3/6] mt76: mt76x02: add check for invalid vif idx Markus Theil
2019-11-26 21:47 ` [PATCH v9 4/6] mt76: mt76x02: remove a copy call for usb speedup Markus Theil
2019-12-17 9:40 ` Lorenzo Bianconi
2019-12-18 12:11 ` Markus Theil
2019-12-18 13:17 ` Lorenzo Bianconi
2019-12-18 14:57 ` Markus Theil
2019-11-26 21:47 ` [PATCH v9 5/6] mt76: speed up usb bulk copy Markus Theil
2019-11-26 21:47 ` [PATCH v9 6/6] mt76: mt76x02: add channel switch support for usb interfaces Markus Theil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191218093733.GA13035@localhost.localdomain \
--to=lorenzo.bianconi@redhat.com \
--cc=linux-wireless@vger.kernel.org \
--cc=markus.theil@tu-ilmenau.de \
--cc=nbd@nbd.name \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).