From: Kalle Valo <kvalo@codeaurora.org>
To: John Crispin <john@phrozen.org>
Cc: linux-wireless@vger.kernel.org, ath11k@lists.infradead.org,
John Crispin <john@phrozen.org>
Subject: Re: [PATCH V3 8/9] ath11k: optimise ath11k_dp_tx_completion_handler
Date: Wed, 18 Dec 2019 11:44:30 +0000 (UTC) [thread overview]
Message-ID: <20191218114430.04CA1C433CB@smtp.codeaurora.org> (raw)
In-Reply-To: <20191213153839.12372-9-john@phrozen.org>
John Crispin <john@phrozen.org> wrote:
> the current code does 4 memcpys for each completion frame.
> 1) duplicate the desc
> 2 + 3) inside kfifo insertion
> 4) kfifo remove
>
> The code simply drops the kfifo and uses a trivial ring buffer. This
> requires a single memcpy for insertion. There is no removal needed as
> we can simply use the inserted data for processing. As the code runs
> inside the NAPI context it is atomic and there is no need for most of
> the locking.
>
> Signed-off-by: John Crispin <john@phrozen.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
This had a new warning, fixed in the pending branch:
drivers/net/wireless/ath/ath11k/dp_tx.c:441: line over 90 characters
--
https://patchwork.kernel.org/patch/11290755/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2019-12-18 11:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-13 15:38 [PATCH V3 0/9] ath11k: resend pending patches John Crispin
2019-12-13 15:38 ` [PATCH V3 1/9] ath11k: add wmi helper for turning STA PS on/off John Crispin
2019-12-18 17:28 ` Kalle Valo
2019-12-13 15:38 ` [PATCH V3 2/9] ath11k: disable PS for STA interfaces by default upon bringup John Crispin
2019-12-13 15:38 ` [PATCH V3 3/9] ath11k: drop memset when setting up a tx cmd desc John Crispin
2019-12-13 15:38 ` [PATCH V3 4/9] ath11k: rename ath11k_wmi_base instances from wmi_sc to wmi_ab John Crispin
2019-12-13 15:38 ` [PATCH V3 5/9] ath11k: add WMI calls to manually add/del/pause/resume TWT dialogs John Crispin
2019-12-18 11:14 ` Kalle Valo
2019-12-13 15:38 ` [PATCH V3 6/9] ath11k: add debugfs for TWT debug calls John Crispin
2019-12-18 11:32 ` Kalle Valo
2019-12-13 15:38 ` [PATCH V3 7/9] ath11k: move some tx_status parsing to debugfs code John Crispin
2019-12-18 11:38 ` Kalle Valo
2019-12-18 17:40 ` Kalle Valo
2019-12-13 15:38 ` [PATCH V3 8/9] ath11k: optimise ath11k_dp_tx_completion_handler John Crispin
2019-12-18 11:44 ` Kalle Valo [this message]
2019-12-13 15:38 ` [PATCH V3 9/9] ath11k: optimize ath11k_hal_tx_status_parse John Crispin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191218114430.04CA1C433CB@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ath11k@lists.infradead.org \
--cc=john@phrozen.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).