Linux wireless drivers development
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Luca Coelho <luca@coelho.fi>
Cc: stable@vger.kernel.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v5.4] Revert "iwlwifi: assign directly to iwl_trans->cfg in QuZ detection"
Date: Wed, 1 Jan 2020 18:02:06 +0100	[thread overview]
Message-ID: <20200101170206.GC2712976@kroah.com> (raw)
In-Reply-To: <20191223125612.1475700-1-luca@coelho.fi>

On Mon, Dec 23, 2019 at 02:56:12PM +0200, Luca Coelho wrote:
> From: Anders Kaseorg <andersk@mit.edu>
> 
> This reverts commit 968dcfb4905245dc64d65312c0d17692fa087b99.
> 
> Both that commit and commit 809805a820c6445f7a701ded24fdc6bbc841d1e4
> attempted to fix the same bug (dead assignments to the local variable
> cfg), but they did so in incompatible ways. When they were both merged,
> independently of each other, the combination actually caused the bug to
> reappear, leading to a firmware crash on boot for some cards.
> 
> https://bugzilla.kernel.org/show_bug.cgi?id=205719
> 
> Signed-off-by: Anders Kaseorg <andersk@mit.edu>
> Acked-by: Luca Coelho <luciano.coelho@intel.com>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
> ---
>  drivers/net/wireless/intel/iwlwifi/pcie/drv.c | 24 +++++++++----------
>  1 file changed, 12 insertions(+), 12 deletions(-)
> 

Next time a hint as to what this git commit id is in Linus's tree would
be nice :)

thanks,

greg k-h

  reply	other threads:[~2020-01-01 17:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-23 12:56 [PATCH v5.4] Revert "iwlwifi: assign directly to iwl_trans->cfg in QuZ detection" Luca Coelho
2020-01-01 17:02 ` Greg KH [this message]
2020-01-01 17:56   ` Luca Coelho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200101170206.GC2712976@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=luca@coelho.fi \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox