From: Nathan Chancellor <natechancellor@gmail.com>
To: yhchuang@realtek.com
Cc: kvalo@codeaurora.org, linux-wireless@vger.kernel.org,
briannorris@chromium.org
Subject: Re: [PATCH 5.6] rtw88: Fix return value of rtw_wow_check_fw_status
Date: Sun, 2 Feb 2020 23:13:15 -0700 [thread overview]
Message-ID: <20200203061315.GA6067@ubuntu-x2-xlarge-x86> (raw)
In-Reply-To: <20200203060157.15330-1-yhchuang@realtek.com>
On Mon, Feb 03, 2020 at 02:01:57PM +0800, yhchuang@realtek.com wrote:
> From: Chin-Yen Lee <timlee@realtek.com>
>
> Clang warns that ret is used uninitialzed.
> And we found that actually the return type should be "int" instead
> of "bool".
>
> Fixes: 44bc17f7f5b3 ("rtw88: support wowlan feature for 8822c")
> Link: https://github.com/ClangBuiltLinux/linux/issues/850
> Reported-by: Nathan Chancellor <natechancellor@gmail.com>
> Signed-off-by: Chin-Yen Lee <timlee@realtek.com>
> Signed-off-by: Yan-Hsuan Chuang <yhchuang@realtek.com>
Looks good to me, thank you for the fix and keeping my tags :)
Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
Tested-by: Nathan Chancellor <natechancellor@gmail.com> # build
next prev parent reply other threads:[~2020-02-03 6:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-03 6:01 [PATCH 5.6] rtw88: Fix return value of rtw_wow_check_fw_status yhchuang
2020-02-03 6:13 ` Nathan Chancellor [this message]
2020-02-03 18:10 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200203061315.GA6067@ubuntu-x2-xlarge-x86 \
--to=natechancellor@gmail.com \
--cc=briannorris@chromium.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=yhchuang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox