From: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To: Felix Fietkau <nbd@nbd.name>
Cc: Lorenzo Bianconi <lorenzo@kernel.org>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/3] mt76: reuse mt76_mcu in mt76u_mcu
Date: Fri, 7 Feb 2020 18:29:24 +0100 [thread overview]
Message-ID: <20200207172924.GB2538@localhost.localdomain> (raw)
In-Reply-To: <3b5b64dd-8939-b730-5b2c-f720a8e1d001@nbd.name>
[-- Attachment #1: Type: text/plain, Size: 625 bytes --]
On Feb 07, Felix Fietkau wrote:
> On 2020-02-06 00:53, Lorenzo Bianconi wrote:
> > Introduce mt76_mcu data structure to contain common fields between
> > mt76u_mcu and mt76e_mcu.
> > Move mt76u_mcu at the beginning of mt76_usb in order to rely on mt76_mcu
> > to access mt76u_mcu common fields
> Why not move it to struct mt76_dev directly and out of the union?
> I think that would be cleaner, and you can also initialize its fields in
> mt76_alloc_device().
ack and I can maintain the usb specific fields (e.g mt76_reg_pair or burst) in
mt76u_mcu. I will fix it in v2
Regards,
Lorenzo
>
> - Felix
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2020-02-07 17:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-05 23:53 [PATCH 0/3] remove mmio dependency from mcu event code Lorenzo Bianconi
2020-02-05 23:53 ` [PATCH 1/3] mt76: reuse mt76_mcu in mt76u_mcu Lorenzo Bianconi
2020-02-07 17:11 ` Felix Fietkau
2020-02-07 17:29 ` Lorenzo Bianconi [this message]
2020-02-05 23:53 ` [PATCH 2/3] mt76: generalize mt76_mcu_rx_event routine Lorenzo Bianconi
2020-02-07 17:12 ` Felix Fietkau
2020-02-07 17:22 ` Lorenzo Bianconi
2020-02-05 23:53 ` [PATCH 3/3] mt76: generalize mt76_mcu_get_response routine Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200207172924.GB2538@localhost.localdomain \
--to=lorenzo.bianconi@redhat.com \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox