From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88F54C3B187 for ; Tue, 11 Feb 2020 06:59:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5E64C206D7 for ; Tue, 11 Feb 2020 06:59:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="SfBU9j5j" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728069AbgBKG7K (ORCPT ); Tue, 11 Feb 2020 01:59:10 -0500 Received: from userp2120.oracle.com ([156.151.31.85]:44970 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728063AbgBKG7K (ORCPT ); Tue, 11 Feb 2020 01:59:10 -0500 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 01B6x4IL175665; Tue, 11 Feb 2020 06:59:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=3/RgUTylOj363dbYQdeISiquGp5Fp3ARSlcrIMOOwRY=; b=SfBU9j5jq7OMa5GLHJ7NqdGjhC/cpzLXsAl/Su/PW3cccKpWIBXBPRX1n8VmWa+6rLuQ hq8vbNg6m4GZ8mR/lY1s3ydgZTjUro4mT+BO86o3JUSmm19yvQhguLGKneG2TYaABVJi jU4qFDRA1+ug26V3q3DXz8dJc6yWS5MO/BDWgrKNnVFqw/esEpKAwiH2CSpk9xFs1LNX 6Br2XEhlBKEK/jw6lPp6y9myVXk2vuSWdn8LH615DdS3WZKIPJrCcETPviHOKBQkghVK MboIdpZVGn4l0FykTjQbI4b13OU/dGtpE/kTQ3Ix1D+OsGhvAGqx/f2YkIDgztKglcTx AQ== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2120.oracle.com with ESMTP id 2y2p3s96bu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 11 Feb 2020 06:59:04 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 01B6wk0k139430; Tue, 11 Feb 2020 06:59:04 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3020.oracle.com with ESMTP id 2y26q0qfkf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 11 Feb 2020 06:59:04 +0000 Received: from abhmp0009.oracle.com (abhmp0009.oracle.com [141.146.116.15]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 01B6x3DX007303; Tue, 11 Feb 2020 06:59:03 GMT Received: from kadam (/129.205.23.165) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 10 Feb 2020 22:59:02 -0800 Date: Tue, 11 Feb 2020 09:58:56 +0300 From: Dan Carpenter To: Ajay.Kathat@microchip.com Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, johannes@sipsolutions.net, linux-wireless@vger.kernel.org, Adham.Abozaeid@microchip.com Subject: Re: [PATCH 3/3] staging: wilc1000: refactor p2p action frames handling API's Message-ID: <20200211065856.GD1778@kadam> References: <20200211000652.4781-1-ajay.kathat@microchip.com> <20200211000652.4781-3-ajay.kathat@microchip.com> <20200211065101.GC1778@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200211065101.GC1778@kadam> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9527 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 bulkscore=0 spamscore=0 mlxscore=0 adultscore=0 suspectscore=1 mlxlogscore=999 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2002110050 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9527 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxscore=0 malwarescore=0 suspectscore=1 mlxlogscore=999 priorityscore=1501 clxscore=1015 impostorscore=0 lowpriorityscore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2002110050 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Tue, Feb 11, 2020 at 09:51:01AM +0300, Dan Carpenter wrote: > On Mon, Feb 10, 2020 at 06:36:01PM +0000, Ajay.Kathat@microchip.com wrote: > > + if (sta_ch == WILC_INVALID_CHANNEL) > > + return; > > > > while (index < len) { > > This range checking was there in the original code, but it's not > correct. index and len are in terms of bytes so we know that we can > read one byte from &buf[index] but we are reading a wilc_attr_entry > struct which is larger than a type. The struct is actually flexibly ^^^^ I meant byte. regards, dan carpenter