From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F993C352A4 for ; Wed, 12 Feb 2020 16:23:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EB39020724 for ; Wed, 12 Feb 2020 16:23:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="xc868N6q" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728575AbgBLQXN (ORCPT ); Wed, 12 Feb 2020 11:23:13 -0500 Received: from mail26.static.mailgun.info ([104.130.122.26]:49982 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727669AbgBLQXN (ORCPT ); Wed, 12 Feb 2020 11:23:13 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1581524592; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=zJskcSQLL84R/a3/Q1iH01qdPucMx4GgSmjyfRstz9w=; b=xc868N6qgzqBgU26P9ZBOT44nJf/7pHpGVsc9EQ1qPp3rPSrG2OSAnlR17u/g2X5jPuWU1Db 7qK8kjpZbSfQ6dCe8CZJO4RdgdHco4esoMJuyIeWbmVfgXNfSC1f3IBPDs+t7zLxO1fud4SN hBheP+iOaJqy6F40cizRUF8Gxcw= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e442670.7f2b884a3ca8-smtp-out-n02; Wed, 12 Feb 2020 16:23:12 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 218B1C4479C; Wed, 12 Feb 2020 16:23:11 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 365C5C433A2; Wed, 12 Feb 2020 16:23:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 365C5C433A2 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] rtw88: 8822[bc]: Make tables const, reduce data object size From: Kalle Valo In-Reply-To: <4ba111ba18f14f0630cc550b58dbe5dbc82a48ac.camel@perches.com> References: <4ba111ba18f14f0630cc550b58dbe5dbc82a48ac.camel@perches.com> To: Joe Perches Cc: Yan-Hsuan Chuang , "David S. Miller" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20200212162311.218B1C4479C@smtp.codeaurora.org> Date: Wed, 12 Feb 2020 16:23:11 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Joe Perches wrote: > Reduce the data size 2kb or 3kb by making tables const. > Add const to pointer declarations to make compilation work too. > > (x86-64 defconfig) > $ size drivers/net/wireless/realtek/rtw88/rtw8822?.o* > text data bss dec hex filename > 25054 672 8 25734 6486 drivers/net/wireless/realtek/rtw88/rtw8822b.o.new > 23870 1872 8 25750 6496 drivers/net/wireless/realtek/rtw88/rtw8822b.o.old > 53646 828 0 54474 d4ca drivers/net/wireless/realtek/rtw88/rtw8822c.o.new > 52846 1652 0 54498 d4e2 drivers/net/wireless/realtek/rtw88/rtw8822c.o.old > > (x86-64 allyesconfig) > $ size drivers/net/wireless/realtek/rtw88/rtw8822?.o* > text data bss dec hex filename > 45811 6280 128 52219 cbfb drivers/net/wireless/realtek/rtw88/rtw8822b.o.new > 44211 7880 128 52219 cbfb drivers/net/wireless/realtek/rtw88/rtw8822b.o.old > 100195 8128 0 108323 1a723 drivers/net/wireless/realtek/rtw88/rtw8822c.o.new > 98947 9376 0 108323 1a723 drivers/net/wireless/realtek/rtw88/rtw8822c.o.old > > Signed-off-by: Joe Perches > Acked-by: Yan-Hsuan Chuang Patch applied to wireless-drivers-next.git, thanks. d49f2c5063fd rtw88: 8822[bc]: Make tables const, reduce data object size -- https://patchwork.kernel.org/patch/11368195/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches