From: Kalle Valo <kvalo@codeaurora.org>
To: Sriram R <srirrama@codeaurora.org>
Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
Sriram R <srirrama@codeaurora.org>,
Tamizh Chelvam Raja <tamizhr@codeaurora.org>
Subject: Re: [PATCHv2 2/2] ath11k: Perform per-msdu rx processing
Date: Wed, 11 Mar 2020 16:17:38 +0000 (UTC) [thread overview]
Message-ID: <20200311161738.BE683C43636@smtp.codeaurora.org> (raw)
In-Reply-To: <1581908873-14749-3-git-send-email-srirrama@codeaurora.org>
Sriram R <srirrama@codeaurora.org> wrote:
> As Hash based reo destination selection is configured,
> the decapped packets reach different reo destintion rings
> based on the destintaion ring selected for the computed hash (based on
> the 5-tuple {ip src/ip dst/src port/dst port/protocol}) by hw and
> as configured by driver.
>
> Hence the current implementation of amsdu list based processing after all
> the subframes of amsdu are received (since all msdu's for a pdev are
> received in same reo dest ring), is not applicable here and hence is
> replaced with per msdu based handling as these subframes
> can be received in different reo dest rings.
>
> Also, as some of the rx descriptor fields might be valid only for the
> first msdu (for ex. received 80211 header, encryption type, etc),
> it might not be useful now as we cannot sync between different
> subframes received in different rings. Hence do not rely on those
> fields and replace them with fieds valid only on per msdu descriptors.
> Also cache other details such as encryption type for a peer so that
> it can be reused when a packet is received from it.
>
> Co-developed-by: Tamizh Chelvam Raja <tamizhr@codeaurora.org>
> Signed-off-by: Tamizh Chelvam Raja <tamizhr@codeaurora.org>
> Signed-off-by: Sriram R <srirrama@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
New warnings:
drivers/net/wireless/ath/ath11k/dp_rx.c:2010: multiple assignments should be avoided
drivers/net/wireless/ath/ath11k/dp_rx.c:2160: Please don't use multiple blank lines
Fixed in the pending branch.
--
https://patchwork.kernel.org/patch/11385033/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2020-03-11 16:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-17 3:07 [PATCHv2 0/2] Support hash based reo destination ring selection Sriram R
2020-02-17 3:07 ` [PATCHv2 1/2] ath11k: Configure " Sriram R
2020-03-12 13:13 ` Kalle Valo
2020-02-17 3:07 ` [PATCHv2 2/2] ath11k: Perform per-msdu rx processing Sriram R
2020-03-11 16:17 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200311161738.BE683C43636@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ath11k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=srirrama@codeaurora.org \
--cc=tamizhr@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).