From: Kalle Valo <kvalo@codeaurora.org>
To: Chi-Hsien Lin <chi-hsien.lin@cypress.com>
Cc: linux-wireless@vger.kernel.org, brcm80211-dev-list@broadcom.com,
brcm80211-dev-list@cypress.com,
Arend van Spriel <arend.vanspriel@broadcom.com>,
Franky Lin <franky.lin@broadcom.com>,
Hante Meuleman <hante.meuleman@broadcom.com>,
Wright Feng <wright.feng@cypress.com>,
Raveendran Somu <raveendran.somu@cypress.com>,
Chi-hsien Lin <chi-hsien.lin@cypress.com>
Subject: Re: [PATCH V2 1/6] brcmfmac: Fix driver crash on USB control transfer timeout
Date: Mon, 23 Mar 2020 17:32:39 +0000 (UTC) [thread overview]
Message-ID: <20200323173239.5FA3DC433CB@smtp.codeaurora.org> (raw)
In-Reply-To: <1584096620-101123-2-git-send-email-chi-hsien.lin@cypress.com>
Chi-Hsien Lin <chi-hsien.lin@cypress.com> wrote:
> From: Raveendran Somu <raveendran.somu@cypress.com>
>
> When the control transfer gets timed out, the error status
> was returned without killing that urb, this leads to using
> the same urb. This issue causes the kernel crash as the same
> urb is sumbitted multiple times. The fix is to kill the
> urb for timeout transfer before returning error
>
> Signed-off-by: Raveendran Somu <raveendran.somu@cypress.com>
> Signed-off-by: Chi-hsien Lin <chi-hsien.lin@cypress.com>
Fails to build:
drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c: In function 'brcmf_usb_rx_ctlpkt':
drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c:390:3: error: label 'fail' used but not defined
goto fail;
^~~~
make[6]: *** [drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.o] Error 1
make[6]: *** Waiting for unfinished jobs....
make[5]: *** [drivers/net/wireless/broadcom/brcm80211/brcmfmac] Error 2
make[4]: *** [drivers/net/wireless/broadcom/brcm80211] Error 2
make[3]: *** [drivers/net/wireless/broadcom] Error 2
make[2]: *** [drivers/net/wireless] Error 2
make[1]: *** [drivers/net] Error 2
make: *** [drivers] Error 2
6 patches set to Changes Requested.
11436667 [V2,1/6] brcmfmac: Fix driver crash on USB control transfer timeout
11436669 [V2,2/6] brcmfmac: Fix double freeing in the fmac usb data path
11436671 [V2,3/6] brcmfmac: fix the incorrect return value in brcmf_inform_single_bss().
11436673 [V2,4/6] brcmfmac: increase max hanger slots from 1K to 3K in fws layer
11436675 [V2,5/6] brcmfmac: add USB autosuspend feature support
11436677 [V2,6/6] brcmfmac: To support printing USB console messages
--
https://patchwork.kernel.org/patch/11436667/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-03-23 17:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 10:50 [PATCH V2 0/6] brcmfmac: USB change series Chi-Hsien Lin
2020-03-13 10:50 ` [PATCH V2 1/6] brcmfmac: Fix driver crash on USB control transfer timeout Chi-Hsien Lin
2020-03-23 17:32 ` Kalle Valo [this message]
2020-03-13 10:50 ` [PATCH V2 2/6] brcmfmac: Fix double freeing in the fmac usb data path Chi-Hsien Lin
2020-03-13 10:50 ` [PATCH V2 3/6] brcmfmac: fix the incorrect return value in brcmf_inform_single_bss() Chi-Hsien Lin
2020-03-13 10:50 ` [PATCH V2 4/6] brcmfmac: increase max hanger slots from 1K to 3K in fws layer Chi-Hsien Lin
2020-03-13 10:50 ` [PATCH V2 5/6] brcmfmac: add USB autosuspend feature support Chi-Hsien Lin
2020-03-13 10:50 ` [PATCH V2 6/6] brcmfmac: To support printing USB console messages Chi-Hsien Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200323173239.5FA3DC433CB@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list@broadcom.com \
--cc=brcm80211-dev-list@cypress.com \
--cc=chi-hsien.lin@cypress.com \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=raveendran.somu@cypress.com \
--cc=wright.feng@cypress.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).