From: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
To: Luca Coelho <luca@coelho.fi>
Cc: johannes@sipsolutions.net, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 12/12] cfg80211: Do not warn on same channel at the end of CSA
Date: Mon, 30 Mar 2020 09:55:31 +0300 [thread overview]
Message-ID: <20200330065530.h5i3reym34jnjs5w@bars> (raw)
In-Reply-To: <20200326120042.578777-13-luca@coelho.fi>
> From: Ilan Peer <ilan.peer@intel.com>
>
> When cfg80211_update_assoc_bss_entry() is called, there is a
> verification that the BSS channel actually changed. As some APs use
> CSA also for bandwidth changes, this would result with a kernel
> warning.
>
> Fix this by removing the WARN_ON().
>
> Change-Id: I6710376b1b4257e5f4712fc7ab16e2b638d512aa
> Signed-off-by: Ilan Peer <ilan.peer@intel.com>
> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
> ---
> net/wireless/scan.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/net/wireless/scan.c b/net/wireless/scan.c
> index dd41e41f9d26..4000382aef48 100644
> --- a/net/wireless/scan.c
> +++ b/net/wireless/scan.c
> @@ -2019,7 +2019,11 @@ void cfg80211_update_assoc_bss_entry(struct wireless_dev *wdev,
>
> spin_lock_bh(&rdev->bss_lock);
>
> - if (WARN_ON(cbss->pub.channel == chan))
> + /*
> + * Some APs use CSA also for bandwidth changes, i.e., without actually
> + * changing the control channel, so no need to update in such a case.
> + */
> + if (cbss->pub.channel == chan)
> goto done;
>
> /* use transmitting bss */
Indeed, that WARN_ON was too harsh here. One more triggering use-case
here was repeater. Thanks for fixing !
Reviewed-by: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
Regards,
Sergey
prev parent reply other threads:[~2020-03-30 7:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 12:00 [PATCH 00/12] cfg80211/mac80211 patches from our internal tree 2020-03-26 Luca Coelho
2020-03-26 12:00 ` [PATCH 01/12] mac80211: implement Operating Mode Notification extended NSS support Luca Coelho
2020-03-26 12:56 ` Kalle Valo
2020-03-26 13:03 ` Luca Coelho
2020-03-26 12:00 ` [PATCH 02/12] mac80211: add twt_protected flag to the bss_conf structure Luca Coelho
2020-03-26 12:00 ` [PATCH 03/12] mac80211: Don't destroy auth data in case of anti-clogging Luca Coelho
2020-03-26 12:00 ` [PATCH 04/12] cfg80211: Parse HE membership selector Luca Coelho
2020-03-26 12:00 ` [PATCH 05/12] mac80211: Skip entries with " Luca Coelho
2020-03-26 12:00 ` [PATCH 06/12] mac80211: agg-tx: refactor sending addba Luca Coelho
2020-03-26 12:00 ` [PATCH 07/12] mac80211: agg-tx: add an option to defer ADDBA transmit Luca Coelho
2020-03-26 12:00 ` [PATCH 08/12] mac80211: Fail association when AP has no legacy rates Luca Coelho
2020-03-26 12:00 ` [PATCH 09/12] mac80211: minstrel_ht_assign_best_tp_rates: remove redundant test Luca Coelho
2020-03-26 12:00 ` [PATCH 10/12] mac80211_hwsim: indicate in IBSS that we have transmitted beacons Luca Coelho
2020-03-26 12:00 ` [PATCH 11/12] mac80211: drop data frames without key on encrypted links Luca Coelho
2020-03-27 15:03 ` Sasha Levin
2020-03-26 12:00 ` [PATCH 12/12] cfg80211: Do not warn on same channel at the end of CSA Luca Coelho
2020-03-30 6:55 ` Sergey Matyukevich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200330065530.h5i3reym34jnjs5w@bars \
--to=sergey.matyukevich.os@quantenna.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=luca@coelho.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox