From: Dan Carpenter <dan.carpenter@oracle.com>
To: Ajay.Kathat@microchip.com
Cc: linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org,
gregkh@linuxfoundation.org, johannes@sipsolutions.net,
lkml@sdf.org, Adham.Abozaeid@microchip.com
Subject: Re: [PATCH v3] staging: wilc1000: Use crc7 in lib/ rather than a private copy
Date: Thu, 2 Apr 2020 11:27:45 +0300 [thread overview]
Message-ID: <20200402082745.GG2001@kadam> (raw)
In-Reply-To: <20200326152251.19094-1-ajay.kathat@microchip.com>
On Thu, Mar 26, 2020 at 03:23:36PM +0000, Ajay.Kathat@microchip.com wrote:
> From: George Spelvin <lkml@SDF.ORG>
>
> The code in lib/ is the desired polynomial, and even includes
> the 1-bit left shift in the table rather than needing to code
> it explicitly.
>
> While I'm in Kconfig, add a description of what a WILC1000 is.
> Kconfig questions that require me to look up a data sheet to
> find out that I probably don't have one are a pet peeve.
>
I don't know how this patch made it through two versions without anyone
complaining that this paragraph should be done as a separate patch...
> Cc: Adham Abozaeid <adham.abozaeid@microchip.com>
> Cc: linux-wireless@vger.kernel.org
> Reviewed-by: Ajay Singh <ajay.kathat@microchip.com>
> Signed-off-by: George Spelvin <lkml@sdf.org>
> ---
This should have you Signed-off-by. The Reviewed-by is kind of assumed
so you can drop that bit. But everyone who touches a patch needs to
add their signed off by.
regards,
dan carpenter
next prev parent reply other threads:[~2020-04-02 8:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 15:23 [PATCH v3] staging: wilc1000: Use crc7 in lib/ rather than a private copy Ajay.Kathat
2020-04-02 8:27 ` Dan Carpenter [this message]
2020-04-02 13:36 ` Ajay.Kathat
2020-04-02 15:30 ` George Spelvin
2020-04-03 9:10 ` Dan Carpenter
2020-04-03 23:40 ` George Spelvin
2020-04-04 10:05 ` Kalle Valo
2020-04-04 17:25 ` Dan Carpenter
2020-04-04 18:15 ` George Spelvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200402082745.GG2001@kadam \
--to=dan.carpenter@oracle.com \
--cc=Adham.Abozaeid@microchip.com \
--cc=Ajay.Kathat@microchip.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=lkml@sdf.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).