From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F95BC43331 for ; Thu, 2 Apr 2020 08:30:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E4F132078E for ; Thu, 2 Apr 2020 08:30:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="i5Rz+dwf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387739AbgDBIaM (ORCPT ); Thu, 2 Apr 2020 04:30:12 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:33948 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387682AbgDBIaL (ORCPT ); Thu, 2 Apr 2020 04:30:11 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0328SgBg045448; Thu, 2 Apr 2020 08:30:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=U+mkRVdl27+gx6adSuTh7F2Z1TVp+AUE66YF/7kfUFw=; b=i5Rz+dwfHuNn9bHUu0m4m4b7e0C6i+2MDYSymVqwl2yLOYrPqG9igxh2/yLq8/w4nWbn BMR4aIYXbaKvzZwAxxHkcfyHNrUj/7me1EVMZK+kHOas1VImniRnmzaCEL8u2ZMH0zpi dr/c3TqXmDCIgTzUgQuj5g90f7cBgWieHH1Wda4ilNoGk5mPXewGCZxKMfd0v5nqya37 tH9+nf28vOGtQODRxjTAnUTdRc6PV4+F7iuUQXlImgnKo2hovknzKuclcNAs/ta6pWMb Jps3cG4vkKkqRHpXCxIl+mRSNI6Xk8Q4hI8zrXqI+MEQkQIZrfR1Yyn/GQEQoBhDKUxi Uw== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2120.oracle.com with ESMTP id 303aqhtbxy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 02 Apr 2020 08:30:00 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0328IIxa090802; Thu, 2 Apr 2020 08:27:59 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3030.oracle.com with ESMTP id 302g4v4ys2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 02 Apr 2020 08:27:59 +0000 Received: from abhmp0020.oracle.com (abhmp0020.oracle.com [141.146.116.26]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 0328Rr5P026828; Thu, 2 Apr 2020 08:27:53 GMT Received: from kadam (/41.57.98.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 02 Apr 2020 01:27:53 -0700 Date: Thu, 2 Apr 2020 11:27:45 +0300 From: Dan Carpenter To: Ajay.Kathat@microchip.com Cc: linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, johannes@sipsolutions.net, lkml@sdf.org, Adham.Abozaeid@microchip.com Subject: Re: [PATCH v3] staging: wilc1000: Use crc7 in lib/ rather than a private copy Message-ID: <20200402082745.GG2001@kadam> References: <20200326152251.19094-1-ajay.kathat@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200326152251.19094-1-ajay.kathat@microchip.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9578 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0 suspectscore=1 mlxscore=0 spamscore=0 malwarescore=0 mlxlogscore=889 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2004020075 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9578 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 phishscore=0 clxscore=1011 malwarescore=0 impostorscore=0 mlxlogscore=954 spamscore=0 mlxscore=0 priorityscore=1501 lowpriorityscore=0 adultscore=0 suspectscore=1 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2004020076 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Thu, Mar 26, 2020 at 03:23:36PM +0000, Ajay.Kathat@microchip.com wrote: > From: George Spelvin > > The code in lib/ is the desired polynomial, and even includes > the 1-bit left shift in the table rather than needing to code > it explicitly. > > While I'm in Kconfig, add a description of what a WILC1000 is. > Kconfig questions that require me to look up a data sheet to > find out that I probably don't have one are a pet peeve. > I don't know how this patch made it through two versions without anyone complaining that this paragraph should be done as a separate patch... > Cc: Adham Abozaeid > Cc: linux-wireless@vger.kernel.org > Reviewed-by: Ajay Singh > Signed-off-by: George Spelvin > --- This should have you Signed-off-by. The Reviewed-by is kind of assumed so you can drop that bit. But everyone who touches a patch needs to add their signed off by. regards, dan carpenter