From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B033AC2BA2B for ; Thu, 9 Apr 2020 14:53:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 85305206E9 for ; Thu, 9 Apr 2020 14:53:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="AJu7SCpR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727868AbgDIOxC (ORCPT ); Thu, 9 Apr 2020 10:53:02 -0400 Received: from mail26.static.mailgun.info ([104.130.122.26]:37177 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726940AbgDIOxB (ORCPT ); Thu, 9 Apr 2020 10:53:01 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1586443981; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=wt9t0SJuUVpHVO0aAU2JawnAeDl2Ka2OOJEFAGaz/7E=; b=AJu7SCpRI04wgug7W9yy9Ir+ucpj8PC1l7vij8Bw9TKJwnokiEAcVJwGnXCPuf1UhhJHGuGJ o4xw3ejLwl2PZ4j2RArWvh1Pz8FiHidqPMUQgEejlgP1Klbrr+l/WnKdgcrJcVVO8HIbN1UY YY/yRVA0o2hS6/9EPNBCEu6P7mw= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e8f36c1.7f61c16f27d8-smtp-out-n01; Thu, 09 Apr 2020 14:52:49 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id BBF47C433D2; Thu, 9 Apr 2020 14:52:48 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 54293C433CB; Thu, 9 Apr 2020 14:52:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 54293C433CB Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v9 1/4] ath10k: disable TX complete indication of htt for sdio From: Kalle Valo In-Reply-To: <20200212080415.31265-2-wgong@codeaurora.org> References: <20200212080415.31265-2-wgong@codeaurora.org> To: Wen Gong Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, wgong@codeaurora.org User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20200409145248.BBF47C433D2@smtp.codeaurora.org> Date: Thu, 9 Apr 2020 14:52:48 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Wen Gong wrote: > For sdio chip, it is high latency bus, all the TX packet's content will > be tranferred from HOST memory to firmware memory via sdio bus, then it > need much more memory in firmware than low latency bus chip, for low > latency chip, such as PCI-E, it only need to transfer the TX descriptor > via PCI-E bus to firmware memory. For sdio chip, reduce the complexity of > TX logic will help TX efficiency since its memory is limited, and it will > reduce the TX circle's time of each packet and then firmware will have more > memory for TX since TX complete also need memeory. > > This patch disable TX complete indication from firmware for htt data > packet, it will not have TX complete indication from firmware to ath10k. > It will cut the cost of bus bandwidth of TX complete and make the TX > logic of firmware simpler, it results in significant performance > improvement on TX path. > > Udp TX throughout is 130Mbps without this patch, and it arrives > 400Mbps with this patch. > > The downside of this patch is the command "iw wlan0 station dump" will > show 0 for "tx retries" and "tx failed" since all tx packet's status > is success. > > This patch only effect sdio chip, it will not effect PCI, SNOC etc. > > Tested with QCA6174 SDIO with firmware > WLAN.RMH.4.4.1-00017-QCARMSWPZ-1 > > Signed-off-by: Wen Gong > Signed-off-by: Kalle Valo 2 patches applied to ath-next branch of ath.git, thanks. d81686d33356 ath10k: disable TX complete indication of htt for sdio c61a74837043 ath10k: change ATH10K_SDIO_BUS_REQUEST_MAX_NUM from 64 to 1024 -- https://patchwork.kernel.org/patch/11377827/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches