public inbox for linux-wireless@vger.kernel.org
 help / color / mirror / Atom feed
From: Jerome Pouiller <Jerome.Pouiller@silabs.com>
To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Kalle Valo" <kvalo@codeaurora.org>,
	"David S . Miller" <davem@davemloft.net>,
	"Jérôme Pouiller" <jerome.pouiller@silabs.com>
Subject: [PATCH 20/20] staging: wfx: update TODO
Date: Wed, 15 Apr 2020 18:11:47 +0200	[thread overview]
Message-ID: <20200415161147.69738-21-Jerome.Pouiller@silabs.com> (raw)
In-Reply-To: <20200415161147.69738-1-Jerome.Pouiller@silabs.com>

From: Jérôme Pouiller <jerome.pouiller@silabs.com>

Update the TODO list associated to the wfx driver with the last
progresses and last remarks made by reviewers.

The items about support for P2P and mesh have also been removed. Indeed,
it seems that the device does not fully support them.

Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
---
 drivers/staging/wfx/TODO | 40 ++++++++++++----------------------------
 1 file changed, 12 insertions(+), 28 deletions(-)

diff --git a/drivers/staging/wfx/TODO b/drivers/staging/wfx/TODO
index efcb7c6a5aa7..fca3332e42ce 100644
--- a/drivers/staging/wfx/TODO
+++ b/drivers/staging/wfx/TODO
@@ -1,26 +1,18 @@
 This is a list of things that need to be done to get this driver out of the
 staging directory.
 
-  - All structures defined in hif_api_*.h are intended to sent/received to/from
-    hardware. All their members whould be declared __le32 or __le16.
-    See:
+  - The HIF API is not yet clean enough.
+
+  - Fix support for big endian architectures. See:
        https://lore.kernel.org/lkml/20191111202852.GX26530@ZenIV.linux.org.uk
 
-  - Once previous item done, it will be possible to audit the driver with
-    `sparse'. It will probably find tons of problems with big endian
-    architectures.
+  - The pointers returned by allocation functions are always checked.
 
-  - hif_api_*.h whave been imported from firmware code. Some of the structures
-    are never used in driver.
+  - The code that check the corectness of received message (in rx_helper()) can
+    be improved. See:
+       https://lore.kernel.org/driverdev-devel/2302785.6C7ODC2LYm@pc-42/
 
-  - Driver try to maintains power save status of the stations. However, this
-    work is already done by mac80211. sta_asleep_mask and pspoll_mask should be
-    dropped.
-
-  - wfx_tx_queues_get() should be reworked. It currently try compute itself the
-    QoS policy. However, firmware already do the job. Firmware would prefer to
-    have a few packets in each queue and be able to choose itself which queue to
-    use.
+  - Support for SDIO with external IRQ is broken.
 
   - As suggested by Felix, rate control could be improved following this idea:
         https://lore.kernel.org/lkml/3099559.gv3Q75KnN1@pc-42/
@@ -28,17 +20,8 @@ staging directory.
   - When driver is about to loose BSS, it forge its own Null Func request (see
     wfx_cqm_bssloss_sm()). It should use mechanism provided by mac80211.
 
-  - AP is actually is setup after a call to wfx_bss_info_changed(). Yet,
-    ieee80211_ops provide callback start_ap().
-
-  - The current process for joining a network is incredibly complex. Should be
-    reworked.
-
   - Monitoring mode is not implemented despite being mandatory by mac80211.
 
-  - "compatible" value are not correct. They should be "vendor,chip". See:
-       https://lore.kernel.org/driverdev-devel/5226570.CMH5hVlZcI@pc-42
-
   - The "state" field from wfx_vif should be replaced by "vif->type".
 
   - It seems that wfx_upload_keys() is useless.
@@ -49,12 +32,13 @@ staging directory.
   - Feature called "secure link" should be either developed (using kernel
     crypto API) or dropped.
 
+  - The device allows to filter multicast traffic. The code to support these
+    filters exists in the driver but it is disabled because it has never been
+    tested.
+
   - In wfx_cmd_send(), "async" allow to send command without waiting the reply.
     It may help in some situation, but it is not yet used. In add, it may cause
     some trouble:
       https://lore.kernel.org/driverdev-devel/alpine.DEB.2.21.1910041317381.2992@hadrien/
     So, fix it (by replacing the mutex with a semaphore) or drop it.
 
-  - Chip support P2P, but driver does not implement it.
-
-  - Chip support kind of Mesh, but driver does not implement it.
-- 
2.25.1


      parent reply	other threads:[~2020-04-15 16:13 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-15 16:11 [PATCH 00/20] staging: wfx: simplify filtering Jerome Pouiller
2020-04-15 16:11 ` [PATCH 01/20] staging: wfx: update filtering even if not connected Jerome Pouiller
2020-04-15 16:11 ` [PATCH 02/20] staging: wfx: simplify wfx_update_filtering() Jerome Pouiller
2020-04-15 16:11 ` [PATCH 03/20] staging: wfx: rework wfx_configure_filter() Jerome Pouiller
2020-04-15 16:11 ` [PATCH 04/20] staging: wfx: simplify handling of beacon filter during join process Jerome Pouiller
2020-04-15 16:11 ` [PATCH 05/20] staging: wfx: wfx_update_filtering_work() is no more used Jerome Pouiller
2020-04-15 16:11 ` [PATCH 06/20] staging: wfx: do not wait for a dtim before associate Jerome Pouiller
2020-04-15 16:11 ` [PATCH 07/20] staging: wfx: disabling beacon filtering after hif_reset() is useless Jerome Pouiller
2020-04-15 16:11 ` [PATCH 08/20] staging: wfx: do not use built-in AUTO_ERP feature Jerome Pouiller
2020-04-15 16:11 ` [PATCH 09/20] staging: wfx: stop changing filtering rule in wfx_hw_scan() Jerome Pouiller
2020-04-15 16:11 ` [PATCH 10/20] staging: wfx: ensure that probe requests are filtered when AP Jerome Pouiller
2020-04-15 16:11 ` [PATCH 11/20] staging: wfx: drop useless wfx_fwd_probe_req() Jerome Pouiller
2020-04-15 16:11 ` [PATCH 12/20] staging: wfx: align semantic of beacon filter with other filters Jerome Pouiller
2020-04-16 13:52   ` Dan Carpenter
2020-04-15 16:11 ` [PATCH 13/20] staging: wfx: align semantic of probe request " Jerome Pouiller
2020-04-15 16:11 ` [PATCH 14/20] staging: wfx: drop struct wfx_grp_addr_table Jerome Pouiller
2020-04-15 16:11 ` [PATCH 15/20] staging: wfx: drop useless call to hif_set_rx_filter() Jerome Pouiller
2020-04-15 16:11 ` [PATCH 16/20] staging: wfx: drop useless attributes 'filter_prbreq' and 'filter_bssid' Jerome Pouiller
2020-04-15 16:11 ` [PATCH 17/20] staging: wfx: split out wfx_filter_beacon() Jerome Pouiller
2020-04-15 16:11 ` [PATCH 18/20] staging: wfx: drop useless filter update when starting AP Jerome Pouiller
2020-04-15 16:11 ` [PATCH 19/20] staging: wfx: drop useless attribute 'filter_mcast' Jerome Pouiller
2020-04-15 16:11 ` Jerome Pouiller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200415161147.69738-21-Jerome.Pouiller@silabs.com \
    --to=jerome.pouiller@silabs.com \
    --cc=davem@davemloft.net \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox