From: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, Kalle Valo <kvalo@codeaurora.org>,
Arend van Spriel <arend.vanspriel@broadcom.com>,
Franky Lin <franky.lin@broadcom.com>,
Hante Meuleman <hante.meuleman@broadcom.com>,
Chi-Hsien Lin <chi-hsien.lin@cypress.com>,
Wright Feng <wright.feng@cypress.com>,
brcm80211-dev-list.pdl@broadcom.com,
brcm80211-dev-list@cypress.com,
Amitkumar Karwar <amitkarwar@gmail.com>,
Ganapathi Bhat <ganapathi.bhat@nxp.com>,
Xinming Hu <huxinming820@gmail.com>,
Igor Mitsyanko <imitsyanko@quantenna.com>,
Sergey Matyukevich <smatyukevich@quantenna.com>,
Johannes Berg <johannes.berg@intel.com>
Subject: Re: [PATCH v2] cfg80211: change internal management frame registration API
Date: Sun, 19 Apr 2020 23:47:30 +0300 [thread overview]
Message-ID: <20200419204729.4rg6etlfzvcnwd32@bars> (raw)
In-Reply-To: <20200417124300.f47f3828afc8.I7f81ef59c2c5a340d7075fb3c6d0e08e8aeffe07@changeid>
> From: Johannes Berg <johannes.berg@intel.com>
>
> Almost all drivers below cfg80211 get the API wrong (except for
> cfg80211) and are unable to cope with multiple registrations for
> the same frame type, which is valid due to the match filter.
> This seems to indicate the API is wrong, and we should maintain
> the full information in cfg80211 instead of the drivers.
>
> Change the API to no longer inform the driver about individual
> registrations and unregistrations, but rather every time about
> the entire state of the entire wiphy and single wdev, whenever
> it may have changed. This also simplifies the code in cfg80211
> as it no longer has to track exactly what was unregistered and
> can free things immediately.
>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> ---
> drivers/net/wireless/ath/ath6kl/cfg80211.c | 26 +++---
> .../broadcom/brcm80211/brcmfmac/cfg80211.c | 19 ++---
> .../net/wireless/marvell/mwifiex/cfg80211.c | 16 ++--
> .../net/wireless/quantenna/qtnfmac/cfg80211.c | 83 ++++++++++---------
> include/net/cfg80211.h | 23 +++--
> include/net/mac80211.h | 2 +-
> net/mac80211/cfg.c | 50 +++++------
> net/mac80211/ieee80211_i.h | 2 +-
> net/wireless/core.c | 7 +-
> net/wireless/core.h | 6 +-
> net/wireless/mlme.c | 72 +++++++---------
> net/wireless/rdev-ops.h | 11 ++-
> net/wireless/trace.h | 20 ++---
> 13 files changed, 159 insertions(+), 178 deletions(-)
Reviewed-by: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
Regards,
Sergey
prev parent reply other threads:[~2020-04-19 20:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 10:43 [PATCH v2] cfg80211: change internal management frame registration API Johannes Berg
2020-04-17 22:08 ` Arend Van Spriel
2020-04-18 20:40 ` Johannes Berg
2020-04-19 20:47 ` Sergey Matyukevich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200419204729.4rg6etlfzvcnwd32@bars \
--to=sergey.matyukevich.os@quantenna.com \
--cc=amitkarwar@gmail.com \
--cc=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211-dev-list@cypress.com \
--cc=chi-hsien.lin@cypress.com \
--cc=franky.lin@broadcom.com \
--cc=ganapathi.bhat@nxp.com \
--cc=hante.meuleman@broadcom.com \
--cc=huxinming820@gmail.com \
--cc=imitsyanko@quantenna.com \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=smatyukevich@quantenna.com \
--cc=wright.feng@cypress.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox