From: Kalle Valo <kvalo@codeaurora.org>
To: Wen Gong <wgong@codeaurora.org>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] ath10k: remove the max_sched_scan_reqs value
Date: Tue, 5 May 2020 07:35:09 +0000 (UTC) [thread overview]
Message-ID: <20200505073509.DC8D8C433BA@smtp.codeaurora.org> (raw)
In-Reply-To: <20191114050001.4658-1-wgong@codeaurora.org>
Wen Gong <wgong@codeaurora.org> wrote:
> The struct cfg80211_wowlan of NET_DETECT WoWLAN feature share the same
> struct cfg80211_sched_scan_request together with scheduled scan request
> feature, and max_sched_scan_reqs of wiphy is only used for sched scan,
> and ath10k does not support scheduled scan request feature, so ath10k
> does not set flag NL80211_FEATURE_SCHED_SCAN_RANDOM_MAC_ADDR, but ath10k
> set max_sched_scan_reqs of wiphy to a non zero value 1, then function
> nl80211_add_commands_unsplit of cfg80211 will set it support command
> NL80211_CMD_START_SCHED_SCAN because max_sched_scan_reqs is a non zero
> value, but actually ath10k not support it, then it leads a mismatch result
> for sched scan of cfg80211, then application shill found the mismatch and
> stop running case of MAC random address scan and then the case fail.
>
> After remove max_sched_scan_reqs value, it keeps match for sched scan and
> case of MAC random address scan pass.
>
> Tested with QCA6174 SDIO with firmware WLAN.RMH.4.4.1-00029.
> Tested with QCA6174 PCIe with firmware WLAN.RM.4.4.1-00110-QCARMSWP-1.
>
> Fixes: ce834e280f2f875 ("ath10k: support NET_DETECT WoWLAN feature")
> Signed-off-by: Wen Gong <wgong@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
d431f8939c14 ath10k: remove the max_sched_scan_reqs value
--
https://patchwork.kernel.org/patch/11243015/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2020-05-05 7:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-14 5:00 [PATCH v2] ath10k: remove the max_sched_scan_reqs value Wen Gong
2020-05-05 7:35 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200505073509.DC8D8C433BA@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=wgong@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).